Fix to windows-latest MSVC lwtnn linkage #334
Merged
nsmith- merged 9 commits intocms-nanoAOD:lwtnnfrom Apr 16, 2026
Merged
Conversation
nsmith-
reviewed
Mar 31, 2026
Author
|
I think there is now a proposed solution, which involves all commits here except the final one. The last commit temporarily points the lwtnn submodule URL at my fork so CI can fetch the MSVC warning-flags fix for validation. Once the corresponding lwtnn PR is merged upstream, I plan to revert that .gitmodules change and update the submodule pointer to the upstream merged commit. |
nsmith-
approved these changes
Apr 16, 2026
Collaborator
nsmith-
left a comment
nsmith-
left a comment
There was a problem hiding this comment.
The CI error is extraneous (will look later)
For now I'll merge it into the main PR, thanks for the help!
| [submodule "lwtnn"] | ||
| path = lwtnn | ||
| url = https://github.com/lwtnn/lwtnn.git | ||
| url = https://github.com/sbein/lwtnn.git |
Collaborator
There was a problem hiding this comment.
You might have noticed my patch is not in that repo either. Actually you can get a commit in any fork on github from the main repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to build on, and if successful, be pulled into or supersede, @nsmith's draft:
#333
It links
lwtnn-staton MSVC builds, sincetarget_link_libraries(correctionlib PRIVATE lwtnn-stat)was inside the non-MSVC branch in
CMakeLists.txt, so may be skipped on Windows.It also fixes correction-config paths for editable installs. Editable installs were showing include/cmake paths from the source tree instead of the installed artifact location, which broke
test_cmake_static_compilation.local checks:
pytest -q tests/test_binding.py -vvpytest -q tests/test_lwtnn.py -vv