Fix: Airlock Electronics requiring the wrong access to modify + ReOrg some access + Misc#12530
Draft
MistChristmas wants to merge 10 commits into
Draft
Fix: Airlock Electronics requiring the wrong access to modify + ReOrg some access + Misc#12530MistChristmas wants to merge 10 commits into
MistChristmas wants to merge 10 commits into
Conversation
Drulikar
requested changes
Jul 4, 2026
| var/obj/effect/decal/cleanable/oldtarget | ||
| var/oldloc = null | ||
| req_access = list(ACCESS_CIVILIAN_ENGINEERING) | ||
| req_access = list(ACCESS_CIVILIAN_ENGINEERING, ACCESS_MARINE_ENGINEERING) |
Contributor
There was a problem hiding this comment.
Were you intentionally trying to make it more restrictive?
| var/turf/oldtarget | ||
| var/oldloc = null | ||
| req_access = list(ACCESS_CIVILIAN_ENGINEERING) | ||
| req_access = list(ACCESS_CIVILIAN_ENGINEERING, ACCESS_MARINE_ENGINEERING) |
Contributor
There was a problem hiding this comment.
Were you intentionally trying to make it more restrictive?
Contributor
Author
There was a problem hiding this comment.
Nope, just me skill issuing
github-project-automation
Bot
moved this from Awaiting Review
to Changes Requested
in Review Backlog
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Resolves: #12415
Airlock Electronics:
We don't actually care about civilian access on setting the access for the electronics, why would we check for it beforehand.
Explain why it's good for the game
Fix good, basically nothing changes apart from IOs get Engineering access, and Synths/SEAs and WJs can use the Airlock Electronics stuff. + The list is slightly better sorted
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑
add: IOs get marine engineering access instead of civilian.
fix: Airlock Electronics + Some other things like Fire doors now accept Marine Engineering access to access.
del: Removes some civilian engineering access from shipside roles.
/:cl: