Skip to content

Fix tower conversion when near a core#12535

Open
Drulikar wants to merge 2 commits into
cmss13-devs:masterfrom
Drulikar:core_cluster_handling
Open

Fix tower conversion when near a core#12535
Drulikar wants to merge 2 commits into
cmss13-devs:masterfrom
Drulikar:core_cluster_handling

Conversation

@Drulikar

@Drulikar Drulikar commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

About the pull request

This PR fixes a niche issue where a cluster is unable to convert a comms tower if the weeds under the tower are controller by a core. Now when weeds are completed for a cluster or when a tower is triggered, it situationally checks if a tower should try conversion regardless of the weeds its on.

I also fixed an issue where the previously qdeleted node remains in the children of the converted pylon (though its a bit goofy that nodes are putting themselves into children).

Explain why it's good for the game

Fixes a non-intuitive aspect of a core preventing tower conversion.

Testing Photographs and Procedure

Screenshots & Videos

https://youtu.be/kuWTWb5rlq4

Changelog

🆑 Drathek
fix: Fixed clusters being unable to convert towers because they're in core weeds
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jun 27, 2026
@cmss13-ci cmss13-ci Bot added Fix Fix one bug, make ten more size/M Denotes a PR that changes 50-199 lines, ignoring generated files. labels Jun 27, 2026
@cmss13-ci

cmss13-ci Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci Bot added the Stale beg a maintainer to review your PR label Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fix one bug, make ten more size/M Denotes a PR that changes 50-199 lines, ignoring generated files. Stale beg a maintainer to review your PR

Projects

Status: Awaiting Review

Development

Successfully merging this pull request may close these issues.

1 participant