Fix timer buckets being reset unnecessarily#12566
Draft
noelle-lavenza wants to merge 2 commits into
Draft
Conversation
cmss13-ci
Bot
added
Missing Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Timer buckets were getting reset unnecessarily due to rounding issues. Change separated out from #11826.
Explain why it's good for the game
Resetting buckets is an expensive operations.
Testing Photographs and Procedure
N/A, backend change. Basic game testing still worked.
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 MoondancerPony
code: made timer buckets do fewer unnecessary resets
code: made the sound_loops timer subsystem reset buckets on tickrate change like timers do
/:cl: