Skip to content

Stops hardened (crash proof) APCs from shorting out.#12571

Open
realforest2001 wants to merge 1 commit into
cmss13-devs:masterfrom
realforest2001:forest/apcshort
Open

Stops hardened (crash proof) APCs from shorting out.#12571
realforest2001 wants to merge 1 commit into
cmss13-devs:masterfrom
realforest2001:forest/apcshort

Conversation

@realforest2001

@realforest2001 realforest2001 commented Jul 2, 2026

Copy link
Copy Markdown
Member

About the pull request

Mainly an issue with ARES, but having every single APC break with 5% chance each tick renders them pointless really as they all will break within a minute.

Explain why it's good for the game

This will at least mean the critical areas are more resistant, and will stop the unreachable APC in ARES from breaking.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: APCs that do not break on crash will not short circuit either.
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jul 2, 2026
@cmss13-ci cmss13-ci Bot added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. size/XS Denotes a PR that changes 0-19 lines, ignoring generated files. labels Jul 2, 2026
@cm13-github

cm13-github commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Test merge deployment history:

Test Merge Deployed @ 07/02/2026 22:27:20 +00:00:
Server Instance

CM13 Live

Revision

Origin: a632830
Pull Request: 0b5f5cb
Server: 19b950c13d1978193007c0961b68f6c63b4dc1e5

Test Merge Updated @ 07/02/2026 23:34:32 +00:00:
Server Instance

CM13 Live

Revision

Origin: a632830
Pull Request: 0b5f5cb
Server: 3392dc0

Test Merge Updated @ 07/03/2026 02:44:59 +00:00:
Server Instance

CM13 Live

Revision

Origin: a632830
Pull Request: 0b5f5cb
Server: 1b83061

Test Merge Updated @ 07/03/2026 03:45:54 +00:00:
Server Instance

CM13 Live

Revision

Origin: 6fcc629
Pull Request: 0b5f5cb
Server: bbcd61ea9b1bd63857ed49dc1e1c61d9fe9bcb05

Test Merge Updated @ 07/03/2026 04:16:41 +00:00:
Server Instance

CM13 Live

Revision

Origin: 6fcc629
Pull Request: 0b5f5cb
Server: f7d6db7

Test Merge Updated @ 07/03/2026 04:25:24 +00:00:
Server Instance

CM13 Live

Revision

Origin: 6fcc629
Pull Request: 0b5f5cb
Server: 5cc5540

Test Merge Updated @ 07/03/2026 05:47:46 +00:00:
Server Instance

CM13 Live

Revision

Origin: c46d658
Pull Request: 0b5f5cb
Server: 1314284be0772b3898f23e9a311f9ba2689512bd

Test Merge Updated @ 07/03/2026 06:31:30 +00:00:
Server Instance

CM13 Live

Revision

Origin: c46d658
Pull Request: 0b5f5cb
Server: c5f638b

Test Merge Updated @ 07/03/2026 07:18:14 +00:00:
Server Instance

CM13 Live

Revision

Origin: c46d658
Pull Request: 0b5f5cb
Server: bad4ec5

Test Merge Updated @ 07/04/2026 00:53:24 +00:00:
Server Instance

CM13 Live

Revision

Origin: 37c049f
Pull Request: 0b5f5cb
Server: 8011e8f7a77e656fbd26ed09fc88ab985e75a352

Test Merge Updated @ 07/04/2026 03:13:06 +00:00:
Server Instance

CM13 Live

Revision

Origin: 37c049f
Pull Request: 0b5f5cb
Server: 5ef7c4f

Test Merge Updated @ 07/04/2026 03:24:45 +00:00:
Server Instance

CM13 Live

Revision

Origin: 82f219f
Pull Request: 0b5f5cb
Server: 7331e71b0b432648028b2d8abf7a17bbc2ce499e

Test Merge Updated @ 07/04/2026 03:55:33 +00:00:
Server Instance

CM13 Live

Revision

Origin: bb16ac6
Pull Request: 0b5f5cb
Server: b2128be42e0b24ea824c93f0fa4102b0f61bff91

Test Merge Updated @ 07/04/2026 05:26:35 +00:00:
Server Instance

CM13 Live

Revision

Origin: 6668a9e
Pull Request: 0b5f5cb
Server: 8e82186

Test Merge Updated @ 07/04/2026 05:46:46 +00:00:
Server Instance

CM13 Live

Revision

Origin: 6668a9e
Pull Request: 0b5f5cb
Server: 7bb46f9

Test Merge Updated @ 07/04/2026 06:57:35 +00:00:
Server Instance

CM13 Live

Revision

Origin: 30f0449
Pull Request: 0b5f5cb
Server: d93cd41

Test Merge Updated @ 07/04/2026 07:14:57 +00:00:
Server Instance

CM13 Live

Revision

Origin: 30f0449
Pull Request: 0b5f5cb
Server: d19887a

Test Merge Updated @ 07/04/2026 09:15:58 +00:00:
Server Instance

CM13 Live

Revision

Origin: 30f0449
Pull Request: 0b5f5cb
Server: 734871a

Test Merge Updated @ 07/04/2026 09:58:55 +00:00:
Server Instance

CM13 Live

Revision

Origin: 30f0449
Pull Request: 0b5f5cb
Server: 686c169

Test Merge Updated @ 07/04/2026 10:59:50 +00:00:
Server Instance

CM13 Live

Revision

Origin: 30f0449
Pull Request: 0b5f5cb
Server: 73ab40c

Test Merge Updated @ 07/04/2026 11:22:52 +00:00:
Server Instance

CM13 Live

Revision

Origin: 30f0449
Pull Request: 0b5f5cb
Server: 94bfdaf

Test Merge Updated @ 07/04/2026 11:30:54 +00:00:
Server Instance

CM13 Live

Revision

Origin: 30f0449
Pull Request: 0b5f5cb
Server: 312cc77

Test Merge Updated @ 07/04/2026 20:33:37 +00:00:
Server Instance

CM13 Live

Revision

Origin: 30f0449
Pull Request: 0b5f5cb
Server: 9b49176

Test Merge Updated @ 07/05/2026 02:05:47 +00:00:
Server Instance

CM13 Live

Revision

Origin: f4cbe98
Pull Request: 0b5f5cb
Server: 108b137a251249fb24c121e53f56549a0d1a4d0d

Test Merge Updated @ 07/05/2026 02:36:47 +00:00:
Server Instance

CM13 Live

Revision

Origin: 83b7e7a
Pull Request: 0b5f5cb
Server: 2fbfe8d2152d29e88da3f520d4d19f20ae510164

Test Merge Updated @ 07/05/2026 04:07:50 +00:00:
Server Instance

CM13 Live

Revision

Origin: 584ce29
Pull Request: 0b5f5cb
Server: 83b86abcc89dffce97601008fb9e6c79f8a04e63

Test Merge Updated @ 07/05/2026 06:16:15 +00:00:
Server Instance

CM13 Live

Revision

Origin: 584ce29
Pull Request: 0b5f5cb
Server: 4f94099

@Drulikar

Drulikar commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Mainly an issue with ARES, but having every single APC break with 5% chance each tick renders them pointless really as they all will break within a minute.

Thats the point. This is not an oversight.

@realforest2001

Copy link
Copy Markdown
Member Author

Mainly an issue with ARES, but having every single APC break with 5% chance each tick renders them pointless really as they all will break within a minute.

Thats the point. This is not an oversight.

I know it's not an oversight. But if you want to render the entire powergrid permanently unusable you should do so directly rather than pretending there's any randomness to it.

Nor should everything everywhere be permanently broken, as stated this is a particular issue with ARES where the APC is unreachable.

@Drulikar

Drulikar commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Mainly an issue with ARES, but having every single APC break with 5% chance each tick renders them pointless really as they all will break within a minute.

Thats the point. This is not an oversight.

I know it's not an oversight. But if you want to render the entire powergrid permanently unusable you should do so directly rather than pretending there's any randomness to it.

Nor should everything everywhere be permanently broken, as stated this is a particular issue with ARES where the APC is unreachable.

The powergrid is no longer allowed to have any available power. The randomness is just to make areas depower randomly over time, but it should be sooner than later (as in not waiting for full cell discharge - especially when APCs can be loaded with some absurdly sized cells). I don't really care about desperate attempts to unshort the APC because it will then later just occur again.

I especially dislike this change affecting hijack strategic areas since marines should already be trying to defend those areas so them not losing power wouldn't affect them. But I'm not keen on say the core being powered then this encouraging marines to flock there.

@realforest2001

Copy link
Copy Markdown
Member Author

If people flock to the core they die. Staff and WJ players can and will eject people from the core by force and staff can make the turrets shoot marines.
I'm happy to make it a variable check so it only applies to ARES core if necessary, but I'm also of the opinion that rendering it impossible for jury rigged local systems to operate is silly. In the event of a ship crashing onto the planet the first thing survivors are likely going to try and do is restore power, even if only locally by rewiring things.

@Drulikar

Drulikar commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Hijack should generally be in xeno's favor. Ground crash is when marines failed so hard at hijack, their ship didn't even start to move away before the xeno's compromised the entire fueling system. It's supposed to be a game state where the ship is fucked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Balance You need to be a professional veteran game maintainer to comprehend what is being done here. size/XS Denotes a PR that changes 0-19 lines, ignoring generated files.

Projects

Status: Awaiting Review

Development

Successfully merging this pull request may close these issues.

3 participants