Changes some logging from key -> ckey#12587
Open
fira wants to merge 1 commit into
Open
Conversation
hry-gh
approved these changes
Jul 5, 2026
Contributor
|
You may want to also update the key usage from #11075 |
Member
Author
|
Looks like pretty much all ckey in there |
Contributor
Every single use of log_mhelp uses .key for example https://github.com/search?q=repo%3Acmss13-devs%2Fcmss13%20log_mhelp&type=code and yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Switches around key for ckey in fingerprints and some logging interactions.
We need ckey in logs for two reasons:
Right now it turns out SAY logs use key not ckey so you can't search them by ckey for example
Doesn't touch adminhelp logs because they're not actual logs (just sent to redis/discord)
Also fixes an invalid emote log and one runtimey fingerprint usage
Removes a weird logging clause in whisper. There's no need for spawn, and the person can't be dead when using it anyway. So now it always logs.
Untested, no way i can manage to check every single one
Changelog
🆑
admin: Most logging (and fingerprints) should now properly use ckey, instead of key
/:cl: