Skip to content

Changes some logging from key -> ckey#12587

Open
fira wants to merge 1 commit into
cmss13-devs:masterfrom
fira:ckey-not-key
Open

Changes some logging from key -> ckey#12587
fira wants to merge 1 commit into
cmss13-devs:masterfrom
fira:ckey-not-key

Conversation

@fira

@fira fira commented Jul 5, 2026

Copy link
Copy Markdown
Member

About the pull request

Switches around key for ckey in fingerprints and some logging interactions.

We need ckey in logs for two reasons:

  • It's what's used in 90% of places, and you can't properly filter if there are several forms of it
  • It's easier and more consistent for parsing logs

Right now it turns out SAY logs use key not ckey so you can't search them by ckey for example

Doesn't touch adminhelp logs because they're not actual logs (just sent to redis/discord)

Also fixes an invalid emote log and one runtimey fingerprint usage
Removes a weird logging clause in whisper. There's no need for spawn, and the person can't be dead when using it anyway. So now it always logs.

Untested, no way i can manage to check every single one

Changelog

🆑
admin: Most logging (and fingerprints) should now properly use ckey, instead of key
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jul 5, 2026
@cmss13-ci cmss13-ci Bot added Admin Make things harder for admins size/M Denotes a PR that changes 50-199 lines, ignoring generated files. labels Jul 5, 2026
@github-project-automation github-project-automation Bot moved this from Awaiting Review to Partially Approved / Mergeable in Review Backlog Jul 5, 2026
@Drulikar

Drulikar commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

You may want to also update the key usage from #11075

@fira

fira commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

Looks like pretty much all ckey in there

@Drulikar

Drulikar commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Looks like pretty much all ckey in there

Every single use of log_mhelp uses .key for example https://github.com/search?q=repo%3Acmss13-devs%2Fcmss13%20log_mhelp&type=code and yes author_key is itself a .key too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Make things harder for admins size/M Denotes a PR that changes 50-199 lines, ignoring generated files.

Projects

Status: Partially Approved / Mergeable

Development

Successfully merging this pull request may close these issues.

3 participants