Skip to content

feat(utils): add NodeJS profiler #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BioPhoton wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(utils): add NodeJS profiler #1219

BioPhoton wants to merge 6 commits into from

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Jan 16, 2026

Related: #1197

This PR includes:

  • adding NodeJSProfiler class
  • implemented performanceObserver for NodeJSProfiler

@BioPhoton
feat: add NodeJSProfiler
b71f3c7
@BioPhoton
docs: clarify that sink defines output format in NodejsProfiler JSDoc
d8d5a93 
- Add explanation that sink determines output format (DevTools TraceEvent, OpenTelemetry, etc.)
- Improve documentation clarity for flexible serialization capabilities
- Fix duplicate imports in profiler unit test
@BioPhoton
test: convert all MockSink and MockTraceEventFileSink methods to spies
673b5c4 
- Replace method implementations with vi.fn() spy functions
- Add vi import from vitest
- Enables better testing with call tracking and assertions
@BioPhoton
refactor: add tests
7c14a0b
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 utils labels Jan 16, 2026
@nx-cloud
Copy link

nx-cloud bot commented Jan 16, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit d328c9f

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 27s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 13m 1s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 49s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-16 22:39:08 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 16, 2026 •
edited
Loading

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1219

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1219

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1219

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1219

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1219

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1219

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1219

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1219

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1219

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1219

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1219

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1219

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1219

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1219

commit: d328c9f

@BioPhoton BioPhoton mentioned this pull request Jan 16, 2026
Open
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 0cc093e with previous commit 270b474.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 42 🔴 43 ↑ +0.9
Performance 🔴 37 🔴 37 ↓ −0.4
Code coverage 🟢 93 🟢 93 ↑ +0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 99 🟢 99 –
Security 🟡 51 🟡 51 –
Updates 🟡 78 🟡 78 –
Type Safety 🟡 67 🟡 67 –
Miscellaneous 🟡 67 🟡 67 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟢 92 🟢 92 –
👍 2 groups improved, 👎 1 group regressed, 👍 6 audits improved, 👎 3 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 42 🔴 43 ↑ +0.9
Lighthouse Performance 🔴 37 🔴 37 ↓ −0.4
Code coverage Code coverage metrics 🟢 93 🟢 93 ↑ +0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.4 s ↑ +9.8 %
JSDocs coverage Classes coverage 🟥 6 undocumented classes 🟥 6 undocumented classes +0 %
Lighthouse Speed Index 🟥 6.0 s 🟥 6.3 s ↑ +4.3 %
Lighthouse Total Blocking Time 🟥 1,890 ms 🟥 1,640 ms ↓ −13.2 %
JSDocs coverage Methods coverage 🟨 13 undocumented methods 🟨 14 undocumented methods ↑ +7.7 %
JSDocs coverage Types coverage 🟥 268 undocumented types 🟥 268 undocumented types +0 %
Code coverage Line coverage 🟩 92.7 % 🟩 92.7 % ↑ +0.1 %
Code coverage Function coverage 🟩 94.4 % 🟩 94.4 % ↑ +0.1 %
Code coverage Branch coverage 🟨 89 % 🟨 89 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,104 KiB 🟩 Total size was 2,106 KiB ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 9.2 s 🟥 8.6 s ↓ −6.9 %
Lighthouse Server Backend Latencies 🟩 1,200 ms 🟩 920 ms ↓ −23.2 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 224 KiB 🟥 Potential savings of 225 KiB ↓ −19.7 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↓ −0.1 %
Lighthouse Largest Contentful Paint 🟥 11.5 s 🟥 11.6 s ↑ +0.9 %
Lighthouse JavaScript execution time 🟥 4.3 s 🟥 4.2 s ↓ −2.3 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 60 ms ↑ +689.3 %
Lighthouse Initial server response time was short 🟩 Root document took 540 ms 🟩 Root document took 520 ms ↓ −4 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↑ +3.3 %
Lighthouse Max Potential First Input Delay 🟥 980 ms 🟥 960 ms ↓ −1.6 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −0.1 %
Lighthouse Time to Interactive 🟥 13.0 s 🟥 13.0 s ↓ −0.1 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 93 KiB 🟥 Potential savings of 93 KiB ↑ +2.2 %
JSDocs coverage Properties coverage 🟥 30 undocumented properties 🟥 33 undocumented properties ↑ +10 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0.003 ↑ +∞ %

654 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review January 16, 2026 22:22
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 0cc093e with previous commit 270b474.

💼 Project utils

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 45 🔴 47 ↑ +1.3
Code coverage 🟢 95 🟢 95 ↑ +0.1

4 other categories are unchanged.

👍 2 groups improved, 👍 3 audits improved, 👎 2 audits regressed, 2 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🔴 45 🔴 47 ↑ +1.3
Code coverage Code coverage metrics 🟢 95 🟢 95 ↑ +0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Classes coverage 🟨 3 undocumented classes 🟨 3 undocumented classes +0 %
JSDocs coverage Types coverage 🟥 66 undocumented types 🟥 66 undocumented types +0 %
JSDocs coverage Methods coverage 🟨 13 undocumented methods 🟨 14 undocumented methods ↑ +7.7 %
Code coverage Function coverage 🟩 96.2 % 🟩 96.2 % ↑ +0.1 %
Code coverage Line coverage 🟩 97.8 % 🟩 97.8 % ↓ −0.1 %
JSDocs coverage Properties coverage 🟥 27 undocumented properties 🟥 30 undocumented properties ↑ +11.1 %
Code coverage Branch coverage 🟩 91.8 % 🟩 91.8 % ↓ −0.1 %

437 other audits are unchanged.

13 other projects are unchanged.

hanna-skryl
hanna-skryl reviewed Jan 16, 2026
View reviewed changes
packages/utils/docs/profiler.md

## Resources

- **[Chrome DevTools Extensibility API](?)** - Official documentation for performance profiling
Copy link
Collaborator

@hanna-skryl hanna-skryl Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the URL intentionally omitted?

packages/utils/src/lib/profiler/profiler.int.test.ts
@@ -1,7 +1,8 @@
import { performance } from 'node:perf_hooks';
import { beforeEach, describe, expect, it } from 'vitest';
import { describe, expect, it } from 'vitest';
Copy link
Collaborator

@hanna-skryl hanna-skryl Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beforeEach is still being used in this file. Why was the import removed?

Suggested change
import { describe, expect, it } from 'vitest';
import { beforeEach, describe, expect, it } from 'vitest';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanna-skryl hanna-skryl hanna-skryl left review comments

@matejchalk matejchalk Awaiting requested review from matejchalk

At least 1 approving review is required to merge this pull request.

Assignees

@BioPhoton BioPhoton

Labels

📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BioPhoton @hanna-skryl