Skip to content

Conversation

@matejchalk
Copy link
Contributor

I updated all the ESLint plugins to their latest versions (except for SonarJS, which will require special attention).

@matejchalk matejchalk self-assigned this Jan 16, 2026
@matejchalk matejchalk requested a review from vmasek January 16, 2026 17:53
Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the preset with new rules.

| [![unicorn](./icons/icons8/unicorn.png)](https://github.com/sindresorhus/eslint-plugin-unicorn#readme) | [consistent-empty-array-spread](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/consistent-empty-array-spread.md)<br />Prefer consistent types when spreading a ternary in an array literal. | | 🔧 | |
| [![unicorn](./icons/icons8/unicorn.png)](https://github.com/sindresorhus/eslint-plugin-unicorn#readme) | [consistent-existence-index-check](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/consistent-existence-index-check.md)<br />Enforce consistent style for element existence checks with `indexOf()`, `lastIndexOf()`, `findIndex()`, and `findLastIndex()`. | | 🔧 | |
| [![unicorn](./icons/icons8/unicorn.png)](https://github.com/sindresorhus/eslint-plugin-unicorn#readme) | [consistent-function-scoping](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/consistent-function-scoping.md)<br />Move function definitions to the highest possible scope. | <details><summary>checkArrowFunctions: false</summary><pre lang="json"><code>{&#13; "checkArrowFunctions": false&#13;}</code></pre></details> | | 🧪🚫 |
| [![unicorn](./icons/icons8/unicorn.png)](https://github.com/sindresorhus/eslint-plugin-unicorn#readme) | [empty-brace-spaces](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/empty-brace-spaces.md)<br />Enforce no spaces between braces. | | 🔧 | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that empty-brace-spaces is very close to a stylistic rule. I noticed that unicorn now has an unopinionated config. Which ruleset do you think is more consistent with the philosophy of this preset?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being opinionated is definitely part of this config's philosophy. This rule specifically is probably redundant if you're using Prettier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants