-
Notifications
You must be signed in to change notification settings - Fork 2
Update plugins #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update plugins #43
Conversation
Tlacenka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the preset with new rules.
| | [](https://github.com/sindresorhus/eslint-plugin-unicorn#readme) | [consistent-empty-array-spread](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/consistent-empty-array-spread.md)<br />Prefer consistent types when spreading a ternary in an array literal. | | 🔧 | | | ||
| | [](https://github.com/sindresorhus/eslint-plugin-unicorn#readme) | [consistent-existence-index-check](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/consistent-existence-index-check.md)<br />Enforce consistent style for element existence checks with `indexOf()`, `lastIndexOf()`, `findIndex()`, and `findLastIndex()`. | | 🔧 | | | ||
| | [](https://github.com/sindresorhus/eslint-plugin-unicorn#readme) | [consistent-function-scoping](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/consistent-function-scoping.md)<br />Move function definitions to the highest possible scope. | <details><summary>checkArrowFunctions: false</summary><pre lang="json"><code>{ "checkArrowFunctions": false }</code></pre></details> | | 🧪🚫 | | ||
| | [](https://github.com/sindresorhus/eslint-plugin-unicorn#readme) | [empty-brace-spaces](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/empty-brace-spaces.md)<br />Enforce no spaces between braces. | | 🔧 | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that empty-brace-spaces is very close to a stylistic rule. I noticed that unicorn now has an unopinionated config. Which ruleset do you think is more consistent with the philosophy of this preset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being opinionated is definitely part of this config's philosophy. This rule specifically is probably redundant if you're using Prettier.
a04f7c8 to
798553b
Compare
I updated all the ESLint plugins to their latest versions (except for SonarJS, which will require special attention).