Fix guarded SKIP in ALT to respect guard expression#82
Merged
associate-1 merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
The codegen was emitting `default:` unconditionally for SKIP cases,
ignoring the guard expression. Now wraps the body in `if guard { ... }`
when a guard is present, so `FALSE & SKIP` correctly prevents the
SKIP branch from executing.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dboreham
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
condition & SKIPin ALT now respects the guard expression instead of always executing the SKIP bodydefault:body is wrapped inif guard { ... }so a false guard prevents executionTestAltBlockWithGuardedSkip) and two E2E tests covering guard TRUE and guard FALSE scenariosTest plan
go test ./parser -run TestAltBlock— parser tests pass (including new guarded SKIP test)go test ./codegen -run TestE2E_AltGuardedSkip— all three E2E ALT SKIP tests passgo test ./...— full test suite passes🤖 Generated with Claude Code