Merged
Conversation
…put was focused before
…meEntryCreateModal from web
…ing in the rows mounting the rows mounts lots of nested components which results in a delay on the initial mount.
Feature Update
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new organization-level permission setting employees_can_manage_tasks that allows employees to manage tasks in projects they have access to, while maintaining proper access controls for private vs public projects. The changes span across backend permission handling, frontend UI components, and various infrastructure improvements including shared UI theme extraction and improved time tracking features.
Key Changes:
- Added
employees_can_manage_taskspermission system for employee task management - Extracted shared Tailwind theme configuration to
@solidtime/uipackage for reuse - Enhanced time tracking UI with manual entry support and improved time range selectors
- Added activity status visualization to calendar view with idle/active period tracking
- Improved type safety and removed duplicate code across components
Reviewed changes
Copilot reviewed 82 out of 88 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Added path alias for @solidtime/ui package |
tests/Unit/Service/PermissionStoreTest.php |
Added comprehensive tests for new employees_can_manage_tasks permission system |
tests/Unit/Endpoint/Api/V1/TaskEndpointTest.php |
Updated task permission tests to use :all permissions and added employee task management tests |
tests/Unit/Endpoint/Api/V1/ClientEndpointTest.php |
Added clients:view:all permission and test for scoped client visibility |
tests/Unit/Console/KernelTest.php |
New test file for console kernel schedule validation |
tailwind.config.js |
Refactored to use shared theme from @solidtime/ui package |
resources/js/utils/useTimeEntries.ts |
Improved type annotations and standardized error handling |
resources/js/utils/useCurrentTimeEntry.ts |
Fixed time entry update to properly handle end times |
resources/js/utils/notification.ts |
Changed login route from route('login') to '/login' |
resources/js/packages/ui/tailwind.theme.js |
New shared Tailwind theme configuration file |
resources/js/packages/ui/styles.css |
New shared CSS styles file |
resources/js/packages/ui/src/utils/time.ts |
Simplified parseTimeInput return type and added HH:MM:SS support |
resources/js/packages/ui/src/utils/cn.ts |
New utility for className merging |
resources/js/packages/ui/src/tooltip/* |
New tooltip component implementation |
resources/js/packages/ui/src/index.ts |
Exported new components and utilities |
resources/js/packages/ui/src/Buttons/* |
Added new Button component with variants |
resources/js/packages/ui/src/TimeTracker/* |
Enhanced with manual entry dropdown and improved range selector |
resources/js/packages/ui/src/TimeEntry/* |
Updated with container queries and improved spacing |
resources/js/packages/ui/src/FullCalendar/* |
Added activity status plugin and running time entry support |
resources/js/packages/ui/package.json |
Version bump and new dependencies added |
resources/js/packages/api/src/openapi.json.client.ts |
Added employees_can_manage_tasks field to organization schema |
resources/js/packages/api/package.json |
Version bump to 0.0.5 |
resources/js/Pages/Time.vue |
Removed manual time entry modal (moved to TimeTracker component) |
Files not reviewed (1)
- resources/js/packages/api/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bumps the minor-updates group with 1 update in the / directory: [dedoc/scramble](https://github.com/dedoc/scramble). Updates `dedoc/scramble` from 0.12.36 to 0.13.6 - [Release notes](https://github.com/dedoc/scramble/releases) - [Commits](dedoc/scramble@v0.12.36...v0.13.6) --- updated-dependencies: - dependency-name: dedoc/scramble dependency-version: 0.13.6 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-updates ... Signed-off-by: dependabot[bot] <support@github.com>
Feature Update
…-updates-7b51c39769 Bump dedoc/scramble from 0.12.36 to 0.13.6 in the minor-updates group across 1 directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.