Component update by julesyan · Pull Request #539 · codefori/vscode-db2i

julesyan · 2026-05-25T19:06:17Z

Update to match the component checking in base extension v3.0.0

Signed-off-by: Julia Yan <julia.yan@ibm.com>

julesyan · 2026-05-25T19:07:27Z

Putting in draft until v3.0.0 is out

sebjulliand · 2026-06-02T07:41:31Z

We should make a note to remove the Mapepire Component from this extension and use the core's now.
We'd need to add support for the JDBC options in the core, but otherwise, it should be fine.

github-actions · 2026-06-02T16:28:34Z

👋 A new build is available for this PR based on b60c26f.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

into version-update

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

julesyan · 2026-06-09T14:28:10Z

I get this when trying to start any SQL job (saved configuration or through the New SQL Job button). I cant run any commands without starting an SQL job.

Is it expected that the SQL Job Manager still exists in Db2i if the job we use is supposed to be the one from Core? If not then does that mean i lose all my configurations?

SanjulaGanepola

Okay, I tried to do hopefully a thorough review of this (lots of changes!) and commented anything and everything I found 😅

Just wanted to point out that it looks like there are a whole lot of type errors still in several files. Are these unrelated to the changes made in this branch? Also not sure why these are not flagged by the build.

SanjulaGanepola · 2026-06-09T23:06:51Z

-    .addSelect(`database name`, `Database name`, [
-      {text: `System Base`, description: `*SYSBAS`, value: ``, selected: options["database name"] === ``},
-      ...Object.values(connection.getAllIAsps()).map(asp => ({text: asp.name, description: asp.name, value: asp.rdbName, selected: options["database name"] === asp.rdbName}))
-    ], formatDescription(dbNameText))


Why do we no longer fetch this and instead rely on the user to set it? From what I see in Code4i, this API is still available.

Is this related to #546 which was just opened? In which case, lets link that issue to this PR too.

That's been removed from the API. The ASP_INFO service that gave us this info cannot be run by any user in 7.6. So listing ASP is not possible anymore, hence the switch to a simple input here.

Oh didn't know that. Is there any alternatives we can use to still fetch this @forstie? Or input box the way to go?

SanjulaGanepola · 2026-06-10T01:21:49Z

@forstie After the comments I just left are addressed, it would be great if you could test this out as well just to make sure nothing was broken.

forstie · 2026-06-10T02:18:19Z

I'm ready to test it when given the go ahead.
It would help to have a brief summary of where to focus testing.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand · 2026-06-10T07:49:17Z

@SanjulaGanepola I tried to fix most of the type errors. It must be ok now (I put //@ts-ignore on some of them because these cases would need more changes).

Co-authored-by: Sanjula Ganepola <32170854+SanjulaGanepola@users.noreply.github.com>

SanjulaGanepola · 2026-06-10T14:48:40Z

@sebjulliand Sounds good, let me know when this is ready for a re-review :)

SanjulaGanepola

Not sure if these type errors are due to changes made in this PR, but thought I would just point them out in case we wanted to fix them here. If they are unrelated, we can maybe leave for a different PR:

Did we ever find why these aren't flagged by the build?

Signed-off-by: Julia Yan <julia.yan@ibm.com>

julesyan · 2026-06-10T15:31:15Z

@SanjulaGanepola resolved the two comments for the components
@sebjulliand the other comments are for your code

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

SanjulaGanepola · 2026-06-10T15:44:32Z

I'm ready to test it when given the go ahead.
It would help to have a brief summary of where to focus testing.

@forstie For testing, this PR doesn't actually have any changes that actually impact functionality. Rather we are no longer installing and have our own mapepire logic in this extension, and instead re-using similar mapepire logic which was added in Code for IBM i. > 3.0.0. However, since this PR does touch a lot of files though, I just tested everything more generally to make sure nothing was broken. I am hoping you can help do the same.

Note: Content assist is not working properly right now, but everything else seems to be good. I have a comment above for that.

Note the VSIX can be found here: #539 (comment)
Also for testing, make sure you are on Code for IBM i 3.0.10.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand · 2026-06-10T16:10:28Z

@SanjulaGanepola I fixed those types issue and the completion (hopefully).
I still don't know why the build doesn't complain about the TS issues...

SanjulaGanepola

Awesome, all looks good on my end

forstie

I'll test post release.

julesyan added 4 commits May 25, 2026 10:57

Initial work for v3.0.0

3ddb61e

Signed-off-by: Julia Yan <julia.yan@ibm.com>

Fix issues with Promise

0e305cd

Signed-off-by: Julia Yan <julia.yan@ibm.com>

Fix issues with Tools import

7a5bd8f

Signed-off-by: Julia Yan <julia.yan@ibm.com>

Finished testing to work with base 3.0.0

bffe6ed

Signed-off-by: Julia Yan <julia.yan@ibm.com>

julesyan requested review from SanjulaGanepola and sebjulliand May 25, 2026 19:06

julesyan marked this pull request as draft May 25, 2026 19:08

julesyan mentioned this pull request May 25, 2026

improve security #524

Closed

julesyan added 6 commits June 2, 2026 12:07

Update package.json

d9f3035

fix import

4648ed2

revert change

090d896

Fix package-lock

7308354

Update nodes version

64dea33

Fix issues with node upgrade

0e26d1f

julesyan marked this pull request as ready for review June 2, 2026 19:23

julesyan linked an issue Jun 3, 2026 that may be closed by this pull request

Syntax checker is not working. #544

Closed

SanjulaGanepola requested changes Jun 8, 2026

View reviewed changes

Comment thread src/connection/components/checkStatement.ts

Comment thread src/connection/components/checkStatement.ts

sebjulliand and others added 2 commits June 8, 2026 18:33

Bumped vscode-ibmi-types to 3.0.9

c24186a

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Merge branch 'version-update' of https://github.com/codefori/vscode-db2i

f8afdde

into version-update

SanjulaGanepola mentioned this pull request Jun 8, 2026

Syntax checker is not working. #544

Closed

sebjulliand added 3 commits June 9, 2026 15:44

Bumped version to 2.0.0

275c0da

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Use Mapepire Component exported from Code for i Core extension

8de8f6b

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Cleaned up dependencies + bumped to node 22

954ce67

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand requested review from a team and SanjulaGanepola June 9, 2026 13:52

sebjulliand added the enhancement New feature or request label Jun 9, 2026

SanjulaGanepola requested changes Jun 10, 2026

View reviewed changes

SanjulaGanepola requested a review from forstie June 10, 2026 01:21

SanjulaGanepola linked an issue Jun 10, 2026 that may be closed by this pull request

mapepire server - use code4i to install it #535

Closed

Fixed type errors

f9fc04a

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

julesyan and others added 5 commits June 10, 2026 07:27

Update src/views/results/index.ts

a5476b1

Co-authored-by: Sanjula Ganepola <32170854+SanjulaGanepola@users.noreply.github.com>

Update channel name

cfc3f44

Co-authored-by: Sanjula Ganepola <32170854+SanjulaGanepola@users.noreply.github.com>

Added missing description

ead8038

Co-authored-by: Sanjula Ganepola <32170854+SanjulaGanepola@users.noreply.github.com>

Fixed display

bd45294

Co-authored-by: Sanjula Ganepola <32170854+SanjulaGanepola@users.noreply.github.com>

Added missing import

bbed8ec

Co-authored-by: Sanjula Ganepola <32170854+SanjulaGanepola@users.noreply.github.com>

sebjulliand linked an issue Jun 10, 2026 that may be closed by this pull request

Edit connection properties button for SQL job manager does not open connection properties #546

Closed

sebjulliand mentioned this pull request Jun 10, 2026

Edit connection properties button for SQL job manager does not open connection properties #546

Closed

sebjulliand requested a review from SanjulaGanepola June 10, 2026 14:57

SanjulaGanepola requested changes Jun 10, 2026

View reviewed changes

Made use of existing functions

dd5d536

Signed-off-by: Julia Yan <julia.yan@ibm.com>

withTempDirectory already gives an absolute path

44f2457

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand added 3 commits June 10, 2026 17:52

Fixed type error + cleaned build routines

84a935e

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Fixed type issue

dafe8ba

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

Fixed action and completion providers

b60c26f

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>

sebjulliand requested a review from SanjulaGanepola June 10, 2026 16:09

SanjulaGanepola approved these changes Jun 10, 2026

View reviewed changes

forstie approved these changes Jun 10, 2026

View reviewed changes

julesyan merged commit 05c1e5e into main Jun 10, 2026
1 check passed

julesyan deleted the component-update branch June 10, 2026 19:22

Conversation

julesyan commented May 25, 2026

Uh oh!

julesyan commented May 25, 2026

Uh oh!

sebjulliand commented Jun 2, 2026

Uh oh!

github-actions Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

julesyan commented Jun 9, 2026

Uh oh!

SanjulaGanepola left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SanjulaGanepola Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

sebjulliand Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

SanjulaGanepola Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SanjulaGanepola commented Jun 10, 2026

Uh oh!

forstie commented Jun 10, 2026

Uh oh!

sebjulliand commented Jun 10, 2026

Uh oh!

SanjulaGanepola commented Jun 10, 2026

Uh oh!

SanjulaGanepola left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

julesyan commented Jun 10, 2026

Uh oh!

SanjulaGanepola commented Jun 10, 2026

Uh oh!

sebjulliand commented Jun 10, 2026

Uh oh!

SanjulaGanepola left a comment

Choose a reason for hiding this comment

Uh oh!

forstie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jun 2, 2026 •

edited

Loading