Skip to content

fix: Status Bar Commit button was calling ROLLBACK instead of COMMIT#548

Merged
worksofliam merged 1 commit into
mainfrom
fix/465-status-bar-commit
Jun 10, 2026
Merged

fix: Status Bar Commit button was calling ROLLBACK instead of COMMIT#548
worksofliam merged 1 commit into
mainfrom
fix/465-status-bar-commit

Conversation

@forstie

@forstie forstie commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Description

The Commit button in the Status Bar was silently performing a ROLLBACK instead of a COMMIT. This was a copy-paste error in the jobCommit command registration — TransactionEndType.ROLLBACK was used where TransactionEndType.COMMIT was intended.

Changes

  • Fixed vscode-db2i.jobManager.jobCommit command to use TransactionEndType.COMMIT instead of TransactionEndType.ROLLBACK

Related Issue

Closes #465

Testing

  1. Set Auto commit = false, Transaction isolation = any non-autocommit value
  2. Execute a DML statement (INSERT/UPDATE/DELETE)
  3. Observe the Status Bar shows a pending transaction indicator
  4. Click Commit in the Status Bar tooltip
  5. Verify the transaction is committed (not rolled back)

@github-actions

Copy link
Copy Markdown
Contributor

👋 A new build is available for this PR based on d934c2e.

@forstie forstie requested a review from worksofliam June 10, 2026 20:27

@worksofliam worksofliam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested together and works as expected

@worksofliam worksofliam merged commit 4e6af53 into main Jun 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Status Bar item Commit/Rollback

2 participants