Skip to content

fix: column autocomplete not working against SYSTEM_TABLE_NAME #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SanjulaGanepola merged 2 commits into from
Jun 12, 2026
Merged

fix: column autocomplete not working against SYSTEM_TABLE_NAME #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee8f72b
fix: column autocomplete for SYSTEM_TABLE_NAME references (#421)
Jun 12, 2026
e559634
chore: ensure package.json ends with newline
Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1937,4 +1937,4 @@
"showdown": "^2.1.0",
"sql-formatter": "^14.0.0"
}
}
}
4 changes: 2 additions & 2 deletions src/database/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default class Table {
* @returns {Promise<TableColumn[]>}
*/
static async getItems(schema: string, table?: string): Promise<TableColumn[]> {
const params = table ? [schema, table] : [schema];
const params = table ? [schema, table, table] : [schema];
const sql = [
`SELECT `,
` column.TABLE_SCHEMA,`,
Expand All @@ -36,7 +36,7 @@ export default class Table {
` column.column_name = key.column_name`,
`WHERE column.TABLE_SCHEMA = ?`,
...[
table ? `AND column.TABLE_NAME = ?` : ``,
table ? `AND (column.TABLE_NAME = ? OR column.SYSTEM_TABLE_NAME = ?)` : ``,
],
`ORDER BY column.ORDINAL_POSITION`,
].join(` `);
Expand Down
Loading