Skip to content

fix for recursive opening of the lib when the object type is *lib#3184

Merged
julesyan merged 4 commits into
codefori:masterfrom
mounigopisetti1162:fix/objectType-lib
Jun 12, 2026
Merged

fix for recursive opening of the lib when the object type is *lib#3184
julesyan merged 4 commits into
codefori:masterfrom
mounigopisetti1162:fix/objectType-lib

Conversation

@mounigopisetti1162

@mounigopisetti1162 mounigopisetti1162 commented May 8, 2026

Copy link
Copy Markdown
Contributor

Changes

Issue
We observed that in the Object Browser, when the object type is specified as *LIB, it results in a recursive loop.

Solution
Added an additional check when the Object Type of the search is *lib

How to test this PR

In the object browser check if you take object type as *lib it should not loop but just return the libraries

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@mounigopisetti1162 mounigopisetti1162 marked this pull request as draft May 8, 2026 11:07
@mounigopisetti1162 mounigopisetti1162 marked this pull request as ready for review May 14, 2026 05:16
@venky225

Copy link
Copy Markdown

@SanjulaGanepola
Fix for the below issue.
image

@mounigopisetti1162

Copy link
Copy Markdown
Contributor Author

Solution for the issue #3188

Comment thread src/api/IBMiContent.ts Outdated
@mounigopisetti1162

Copy link
Copy Markdown
Contributor Author

@SanjulaGanepola kindly look into this once

@julesyan

julesyan commented Jun 9, 2026

Copy link
Copy Markdown
Member

please resolve conflicts

@mounigopisetti1162

Copy link
Copy Markdown
Contributor Author

Resolved the merge conflicts.

@mounigopisetti1162 mounigopisetti1162 force-pushed the fix/objectType-lib branch 2 times, most recently from b7f9418 to 4286860 Compare June 10, 2026 05:15
@julesyan

Copy link
Copy Markdown
Member

Please fix the errors in IBMiContent that show up in the build

@julesyan julesyan self-requested a review June 10, 2026 15:37
@mounigopisetti1162 mounigopisetti1162 force-pushed the fix/objectType-lib branch 3 times, most recently from 08d611f to 4286860 Compare June 12, 2026 06:25
@mounigopisetti1162

Copy link
Copy Markdown
Contributor Author

Fixed the issue
@julesyan

@julesyan julesyan merged commit 4ece5f0 into codefori:master Jun 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants