Fix disabling of components#3202
Merged
Merged
Conversation
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
SanjulaGanepola
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
Contributor
|
👋 A new build is available for this PR based on 9a25efe. |
julesyan
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR is a re-work of #3195. The previous implementation did not actually prevent the component from being installed in the first place as the
ConnectionManageris tied to the connection. By the time we connect and disable, the component may already be installed. This PR changes this logic to use theComponentRegistryto track the set of disabled components instead as this can be done without any connection.Some associated changes in the other extensions:
How to test this PR
Checklist