Fix EVFEVENT errors mapping to server file instead of open local document#3273
Fix EVFEVENT errors mapping to server file instead of open local document#3273neerup wants to merge 2 commits into
Conversation
…ment When compiling a member-type action, `evfeventInfo.workspace` was never set (only `file` actions got a workspace), so the open-document name lookup was skipped and errors always fell through to the server member URI. Fix by moving `findExistingDocumentByName` outside the workspace guard — it searches all open tabs and needs no workspace — so member-type actions now resolve to the locally open file when one matches. Also extend the `fromWorkspace` condition to cover `streamfile` actions, which had the same omission. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
412f22b to
5a010ad
Compare
|
@neerup I'm missing something here. Why should the Workspace actions, run on local files (which are automatically uploaded before running the action), must look into the workspace, no problem. But for members and streamfiles, I don't see why they should 🤔 |
Sorry that is Claude talking :) |
|
Oh ok, so it is related to local actions - you run them from the workspace, not the IFS/Object browser, right? 😅 |
Exactly... |
Fixes #3274
Summary
When compiling a member-type action, clicking an error in the Problems
panel opened the source member on the server instead of the locally open
file.
Root cause:
findExistingDocumentByName— which searches all open editortabs by filename — was inside the
if (evfeventInfo.workspace)guard.For member-type actions
workspaceis never set (onlyfileactionspopulate it), so the lookup was always skipped and errors fell through to
the server member URI.
Fix: move
findExistingDocumentByNameoutside the workspace guard.It needs no workspace context, so it now runs for member-type actions too,
resolving to the locally open file when one matches before falling back to
the server URI.
Test plan
*EVENTFfile-type actions (errors in deployed IFS files still map to local workspace files)🤖 Generated with Claude Code