Skip to content

Fix EVFEVENT errors mapping to server file instead of open local document#3273

Open
neerup wants to merge 2 commits into
codefori:masterfrom
neerup:fix-evfevent-local-file-mapping
Open

Fix EVFEVENT errors mapping to server file instead of open local document#3273
neerup wants to merge 2 commits into
codefori:masterfrom
neerup:fix-evfevent-local-file-mapping

Conversation

@neerup

@neerup neerup commented Jun 10, 2026

Copy link
Copy Markdown

Fixes #3274

Summary

When compiling a member-type action, clicking an error in the Problems
panel opened the source member on the server instead of the locally open
file.

Root cause: findExistingDocumentByName — which searches all open editor
tabs by filename — was inside the if (evfeventInfo.workspace) guard.
For member-type actions workspace is never set (only file actions
populate it), so the lookup was always skipped and errors fell through to
the server member URI.

Fix: move findExistingDocumentByName outside the workspace guard.
It needs no workspace context, so it now runs for member-type actions too,
resolving to the locally open file when one matches before falling back to
the server URI.

Test plan

  • Open a source member locally in the editor
  • Run a compile action that uses *EVENTF
  • Verify that clicking an error in the Problems panel opens the local file, not the server member
  • Verify that workspace deploy-path mapping still works for file-type actions (errors in deployed IFS files still map to local workspace files)

🤖 Generated with Claude Code

…ment

When compiling a member-type action, `evfeventInfo.workspace` was never
set (only `file` actions got a workspace), so the open-document name
lookup was skipped and errors always fell through to the server member URI.

Fix by moving `findExistingDocumentByName` outside the workspace guard —
it searches all open tabs and needs no workspace — so member-type actions
now resolve to the locally open file when one matches.

Also extend the `fromWorkspace` condition to cover `streamfile` actions,
which had the same omission.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@neerup neerup force-pushed the fix-evfevent-local-file-mapping branch from 412f22b to 5a010ad Compare June 10, 2026 07:25
@sebjulliand sebjulliand requested a review from a team June 10, 2026 07:50
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Jun 10, 2026
@sebjulliand

Copy link
Copy Markdown
Member

@neerup I'm missing something here. Why should the member and streamfile actions should look for local files, since they are run on remote members /streamfile?

Workspace actions, run on local files (which are automatically uploaded before running the action), must look into the workspace, no problem. But for members and streamfiles, I don't see why they should 🤔

@neerup

neerup commented Jun 11, 2026

Copy link
Copy Markdown
Author

@neerup I'm missing something here. Why should the member and streamfile actions should look for local files, since they are run on remote members /streamfile?

Workspace actions, run on local files (which are automatically uploaded before running the action), must look into the workspace, no problem. But for members and streamfiles, I don't see why they should 🤔

Sorry that is Claude talking :)
We do local development and we have our own custom compile command. When we compile and the source contains errors, clicking on the error in the werrorview opens the sourcefile on the ifs instead of the local source. In our case we do alot of precompiling before the actual ibm compile, our precompile is a little dated so we copy the ifs source file to QRPGLESRC where all the processing is done and the compile is also done on that source... even if we use the &SRCFILE to have the source copied to tmp source file, it still does not open the local file when clicking on the error in the errorview...
I'm aware of the ENVFEVENT file and the record:
FILEID 0 999 000000 023 QTEMP/QSQLPRE(EG0110RA) 20260610113611 0
FILEID 0 001 000000 025 A4TTHN1/QRPGSRC(EG0110RA) 20260610113607 0
FILEID 0 002 000112 026 EYAS4SRC/QRPGSRC(CS0600RA) 20240815154742 0
The fix works and just opens the local file as expected...
Hope this clarifies...

@sebjulliand

Copy link
Copy Markdown
Member

Oh ok, so it is related to local actions - you run them from the workspace, not the IFS/Object browser, right? 😅

@neerup

neerup commented Jun 11, 2026

Copy link
Copy Markdown
Author

Oh ok, so it is related to local actions - you run them from the workspace, not the IFS/Object browser, right? 😅

Exactly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A confirmed issue when something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking error in Problems panel opens server member instead of local file

2 participants