Skip to content

fix/sourceDateHandler: fix text editor ruler offsetting when source dates in gutter option on#3280

Merged
sebjulliand merged 1 commit into
codefori:masterfrom
borkro:fix/ruler-alignment
Jun 13, 2026
Merged

fix/sourceDateHandler: fix text editor ruler offsetting when source dates in gutter option on#3280
sebjulliand merged 1 commit into
codefori:masterfrom
borkro:fix/ruler-alignment

Conversation

@borkro

@borkro borkro commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Closes #3278

Changes

Replaced the em CSS unit which does not have to align with characters with the ch CSS unit. This fixes editor.rulers alignment.

How to test this PR

  1. Define editor.rulers in vscode settings
  2. Edit connection settings for IBM i server to allow source dates in gutter
  3. Visually inspect ruler position

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@sebjulliand sebjulliand self-requested a review June 13, 2026 09:30
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Jun 13, 2026

@sebjulliand sebjulliand left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks!

@sebjulliand sebjulliand merged commit becbc74 into codefori:master Jun 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A confirmed issue when something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VS Code rulers dont align properly with character boundaries when using source dates in gutter option

2 participants