Support for global RPGLINT configuration path#435
Conversation
Add global lint config path support
Compiled in github codespaces
Add global lint config option
worksofliam
left a comment
There was a problem hiding this comment.
Hey, this is a great start! I am going to need some files removed from this PR:
package-extension.yml- please don't add any new actions to this PR. Perhaps in a separate one if this is something you want to see.- Please remove all
.vsixfiles. We don't want to check them into the repo.
Thanks! Then I will go in for a second review 😄
|
Requested changes completed. |
worksofliam
left a comment
There was a problem hiding this comment.
Sorry this has token so long to get to.
- Can you please fix the formatting in your new changes? They don't match the indentation of the rest of the file.
- Can you fix the conflicts
Thanks!
|
I think we should standardize with Code for IBM i and make use of the |
That is a good idea. I've been thinking about this change, should there also be a switch on/off? |
|
Also I made a typo in my original comment. I meant to type
Great point actually. I'm wondering what would be the best way to support this though. What where you thinking? |
-Correcting indentation. -Adding ignore directories config
|
I have made final changes on my side, making it easier to configure the global files (Not uploaded yet, need testing first). |
Hi Sanjula, Do you think switching to this method would solve for the existing Mapepire issue? Or should I rather wait for them to fix the one I logged? |
Changed global path to use IFS. Brought in line with issue PR fixing lint creation.
|
@worksofliam @SanjulaGanepola |
Changes
This PR adds support for specifying a global RPGLINT config path using the new setting rpgle.globalLintConfigPath.
If checked, linter configs for libraries will be based on IFS's /etc/vscode/rpglint.json.
This helps enforce company-wide lint standards.
Exclude libraries also added, to enable user to add libraries they don't want linted, e.g. browsing prod libraries' source.
Checklist
console.logs I addedThis is my first pull request to anything on github, ever. Please let me know if and where I went wrong so I contribute cleanly in the future.