Added o spec feature#507
Conversation
|
@worksofliam could you please view this pr . |
There was a problem hiding this comment.
I don't see support for columns 81 to 100 for Comments.
I don't see support for Input specs at all, but since the name is o spec I shouldn't expect that.
There are also several different formats for O specs. In my RPGIV2FREE I have:
O: [1, 6, 7, 17, 18, 21, 24, 27, 30, 40, 43, 46, 49], // Record ID: name, type, flag, 3× indicators, EXCEPT, spacing
OAnd: [1, 6, 16, 21, 24, 27, 30], // AND/OR continuation: AND keyword, 3× indicators, EXCEPT name
OF: [1, 6, 21, 24, 27, 30, 44, 45, 47, 52, 53], // Prog-described field: indicators, name, edit code, end pos, constant
OFC: [1, 6, 53], // Field constant continuation
OXF: [1, 6, 21, 24, 27, 30, 45], // Ext-described field: indicators, name, blank-after
...Hope this helps
|
@supravi96 we've had some PRs merged again. Can you please fix the conflicts and I can get this reviewed? Please also see @bobcozzi's comments. |
|
@worksofliam I have resolved the merge conflicts. While implementing support for different O-spec formats, I wanted to check whether we should include comment support in this PR or if it would be better to address it in a follow-up. |
|
@supravi96 just need you to fix the conflicts again and I can test. Thanks! |
|
@worksofliam conflicts are resolved and code is updated and pushed , Requesting you to please review and provide feedback. |
|
@bobcozzi could you please mention the expectation with respect to comments ?it should be displayed in outline or highlighted in the parsed code ? |
|
In short, I think the tab positions of the full spec should be included in case future features need them--I'd like to avoid duplicating structures like these or modifying the existing ones. So everything should be included in the tab poition array. |
|
@bobcozzi what do you recommend they do to close out this PR? I'd like it clean too :) |
|
I'll look at this later today. I'm integrating the CL Command Help Text into the CLPrompter this morning. Once that's operating as designed, I will look at this and provide the full Output Spec's tab positions. |
|
I added a PR that updates the rulers and adds the missing O spec variants. Let me know if you need me to do anything else. |
|
Hi @supravi96 — I tested your changes locally and found one build-breaking issue: Your function detectOSpecType(content: string): 'O' | 'OAnd' | 'OF' | 'OFC' | 'OXF' {Webpack can't parse TypeScript syntax in a Simply renaming the file to Also, separately, I've opened PR #520 which adds correct column ruler and Column Assistant UI support for all five O-spec sub-types (O, OAnd, OF, OFC, OXF) with accurate column positions. That PR and this one are complementary — yours handles parsing, mine handles the editor assist UI. |
Changes
Added comprehensive O-spec (Output Specification) parsing support to the fixed-form RPG parser in language/models/fixed.js.
Changes Made
New Function: parseOLine()
Implemented a complete parser for fixed-form RPG Output specifications that extracts all standard O-spec fields according to IBM i RPG column positions
contributers @Monikacopilot2
Checklist
console.logs I added