Fix #503: Improve caching#519
Open
kluhan wants to merge 9 commits into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…current validateUri calls
Contributor
Author
|
@worksofliam the PR should be ready for review now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(Continuation of #504)
Fix duplicate include loading in RPGLE include graphs and harden cache behavior across parser/server flows.
This addresses the issue where the same include (for example
d.rpgle) could be loaded multiple times when referenced through multiple branches (for example viab.rpgleandc.rpglefroma.rpgle).Problem
See the bug report for details: Issue #503.
What Changed
baseUri::includeString.include -> dependents) to invalidate only affected files.undefinedto deleting entries.CacheMetrics).getFilecontent requests.vscode-rpgle.cache.fileTTLSecondsvscode-rpgle.cache.fileMaxEntriesRPGLE: Clear All Cachescommand.RPGLE: View Cache Statisticscommand.Why This Fixes the Reported Issue
For include graphs like:
the resolver now:
This prevents unnecessary repeated loads of shared include sources and reduces parse overhead for large graphs.
Checklist
console.logs I added