fix(connections): handle IMAP errors to prevent crash on idle timeout#44
Open
hazzcomm wants to merge 3 commits into
Open
fix(connections): handle IMAP errors to prevent crash on idle timeout#44hazzcomm wants to merge 3 commits into
hazzcomm wants to merge 3 commits into
Conversation
Release: CI fixes + Claude action integration
Release: switch claude action to Haiku 4.5
When the IMAP server closes an idle connection (e.g. Dovecot 5-minute socket timeout), imapflow emits an error event on the client. Without a handler, Node crashes with Unhandled error event. Attach an error handler after connect() that logs the event and removes the stale client from the map. The existing usable check in getImapClient() already handles reconnection on the next tool call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the IMAP server closes an idle connection (e.g. Dovecot's default 5-minute socket timeout), imapflow emits an
'error'event on the client. Since no handler is attached, Node crashes with:This takes the MCP server down and requires a Claude Desktop restart to recover.
Fix
Attach an error handler to the ImapFlow client after
connect(). On error, log it and remove the client from the map. The existingusablecheck ingetImapClient()already handles reconnection on the next tool call — it just needs the process to stay alive to reach it.The change is 11 lines. All 150 unit tests pass.
Test plan
pnpm checkcleanpnpm typecheckcleanpnpm test— 150/150 pass🤖 Generated with Claude Code