Skip to content

Advanced Snapping #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mareksuscak wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Advanced Snapping #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e707e5f
Implement advanced snapping
mareksuscak Aug 20, 2020
55c7904
Add snapTo to the list of allowable params
mareksuscak Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/components/core/core-class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,13 @@ class Swiper {
swiper.originalParams = extend({}, swiper.params);
swiper.passedParams = extend({}, params);

// Backward compatibility
if (swiper.params.snapTo === 'center') {
swiper.params.centeredSlides = true;
} else {
swiper.params.centeredSlides = false;
}

// add event listeners
if (swiper.params && swiper.params.on) {
Object.keys(swiper.params.on).forEach((eventName) => {
Expand Down
1 change: 1 addition & 0 deletions src/components/core/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export default {
slidesPerColumnFill: 'column',
slidesPerGroup: 1,
slidesPerGroupSkip: 0,
snapTo: 'start',
centeredSlides: false,
centeredSlidesBounds: false,
slidesOffsetBefore: 0, // in px
Expand Down
28 changes: 20 additions & 8 deletions src/components/core/update/updateSlides.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,12 @@ export default function updateSlides() {
groupIndex === 0
? params.slidesPerGroup
: Math.min(
Math.ceil(
(slidesLength - groupIndex * slidesPerColumn * params.slidesPerGroup) /
slidesPerColumn,
),
params.slidesPerGroup,
);
Math.ceil(
(slidesLength - groupIndex * slidesPerColumn * params.slidesPerGroup) /
slidesPerColumn,
),
params.slidesPerGroup,
);
row = Math.floor(slideIndexInGroup / columnsInGroup);
column = slideIndexInGroup - row * columnsInGroup + groupIndex * params.slidesPerGroup;

Expand Down Expand Up @@ -194,7 +194,19 @@ export default function updateSlides() {
}
slidesSizesGrid.push(slideSize);

if (params.centeredSlides) {
if (params.snapTo === 'end') {
if (i !== 0) slidePosition = slidePosition + slideSize + spaceBetween;
if (Math.abs(slidePosition) < 1 / 1000) slidePosition = 0;
if (params.roundLengths) slidePosition = Math.floor(slidePosition);
if (
(index - Math.min(swiper.params.slidesPerGroupSkip, index)) %
swiper.params.slidesPerGroup ===
0
)
snapGrid.push(Math.max(slidePosition - swiperSize, 0));
slidesGrid.push(Math.max(slidePosition - swiperSize, 0));
if (i === 0) slidePosition = slidePosition + slideSize + spaceBetween;
} else if (params.centeredSlides) {
slidePosition = slidePosition + slideSize / 2 + prevSlideSize / 2 + spaceBetween;
if (prevSlideSize === 0 && i !== 0)
slidePosition = slidePosition - swiperSize / 2 - spaceBetween;
Expand All @@ -207,7 +219,7 @@ export default function updateSlides() {
if (params.roundLengths) slidePosition = Math.floor(slidePosition);
if (
(index - Math.min(swiper.params.slidesPerGroupSkip, index)) %
swiper.params.slidesPerGroup ===
swiper.params.slidesPerGroup ===
0
)
snapGrid.push(slidePosition);
Expand Down
1 change: 1 addition & 0 deletions src/react/params-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const paramsList = [
'_slidesPerColumnFill',
'_slidesPerGroup',
'_slidesPerGroupSkip',
'_snapTo',
'_centeredSlides',
'_centeredSlidesBounds',
'_slidesOffsetBefore',
Expand Down