Open
Conversation
revathskumar
suggested changes
Apr 3, 2018
Contributor
revathskumar
left a comment
revathskumar
left a comment
There was a problem hiding this comment.
Seems to be the implementation needs much more effort. will discuss this.
| Header : (data) => | ||
| <input type="checkbox" className="checkAll" onChange={e => | ||
| data.data.forEach( (val) => e.target.checked ? | ||
| props.handleCheckToggle(val._original.requestId, true) : |
Contributor
There was a problem hiding this comment.
Why there is method call in forEach?
| id: "checkbox", | ||
| accessor: "", | ||
| Header : (data) => | ||
| <input type="checkbox" className="checkAll" onChange={e => |
Contributor
There was a problem hiding this comment.
how to determine if the checkbox is checked or not?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a checkbox as column header which allows the user to check/uncheck all the requests for interception at once