feat(skills): add spec-reviewer skill for technical specification validation#144
Merged
feat(skills): add spec-reviewer skill for technical specification validation#144
Conversation
…ation Add comprehensive tech-lead skill that provides structured guidance for implementing features and tasks: - Requirement gathering from Jira tickets (via brianna) or user descriptions - 5-phase workflow: gathering, analysis, complexity assessment, recommendation, implementation - Complexity rating system (Simple/Medium/Complex) with evidence-based reasoning - Integration with solution-architect skill for complex features - Branch creation and naming conventions (Jira: EPMCDME-XXXXX, non-Jira: feature/name) - Layer-by-layer implementation guidance following project architecture - Reference documentation and example workflows Resolves EPMCDME-10387 Generated with AI Co-Authored-By: codemie-ai <codemie.ai@gmail.com>
…idation Add comprehensive spec-reviewer skill that validates technical specifications from solution-architect: - 4-phase review workflow: input gathering, criteria loading, critical review, verdict - Jira ticket alignment verification (acceptance criteria coverage) - Design principle compliance checking against .codemie/guides/ - Critical violation detection only (no minor issues) - 8 review categories: Architecture, Security, Error Handling, Testing, Integration, Logging, Clarity, Jira Alignment - Binary verdict: APPROVED or NEEDS WORK with focused feedback - No code snippets in feedback (design principle focus only) - Integration with brianna (Jira), solution-architect, and tech-lead skills Reference documentation and examples: - Comprehensive review checklist with decision tree - Violation examples for each category - APPROVED review example - NEEDS WORK review example with 9 critical issues Part of EPMCDME-10387 Generated with AI Co-Authored-By: codemie-ai <codemie.ai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds spec-reviewer skill as part of EPMCDME-10387 to complement the tech-lead skill (already merged in #143).
This PR introduces a comprehensive specification review skill that validates technical specifications from solution-architect against Jira ticket requirements and project design guidelines. The skill acts as a quality gate before implementation begins, ensuring specs follow architectural patterns and address all requirements.
Changes
Spec-Reviewer Skill Implementation (
.claude/skills/spec-reviewer/SKILL.md):.codemie/guides/Reference Documentation:
references/review-checklist.md: Comprehensive checklist for all 8 review categories with decision treereferences/violation-examples.md: Concrete examples of critical violations for each categoryExample Reviews:
examples/approved-review-example.md: Specification that passes all checks (Gemini plugin)examples/needs-work-review-example.md: Specification with 9 critical issues (LiteLLM integration)Impact
Before: No systematic specification review process. Specs could have:
After: Spec-reviewer skill provides:
Workflow Integration
Checklist
Related