Conversation
Member
NautiluX
commented
Feb 6, 2026
NautiluX
commented
- Enables DNS01 challenge for ingress
- Changes order to write configure-k0s script before installing Codesphere
- Runs configure-k0s script after installation (enable installation in one command)
- Allows passing skip steps and hash to bootstrap command
There was a problem hiding this comment.
Pull request overview
This PR enables ACME certificate management for DNS01 challenges in the GCP bootstrapper, allowing automated certificate provisioning via Let's Encrypt. The changes update the installation workflow to configure k0s before installing Codesphere and support additional installation parameters.
Changes:
- Added ACME configuration with DNS01 challenge support using Google Cloud DNS
- Restructured bootstrap flow to generate k0s config script before Codesphere installation
- Enhanced CLI to accept installation hash and skip steps parameters
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/installer/files/config_yaml.go | Added certificate issuer configuration structs and override map for custom certificate settings |
| internal/bootstrap/gcp/mocks.go | Updated mock methods to support multiple IAM roles and service account impersonation |
| internal/bootstrap/gcp/gcp_test.go | Added tests for package validation and updated IAM role assignments with DNS project support |
| internal/bootstrap/gcp/gcp_client.go | Implemented multi-role IAM assignment and service account impersonation for cross-project DNS access |
| internal/bootstrap/gcp/gcp.go | Added ACME configuration, package validation, and reordered bootstrap steps to run k0s config after installation |
| cli/cmd/bootstrap_gcp.go | Added CLI flags for DNS project service account, install hash, and skip steps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
siherrmann
approved these changes
Feb 9, 2026
Member
siherrmann
left a comment
siherrmann
left a comment
There was a problem hiding this comment.
Just one comment/nit/question, else approved.
* Enables DNS01 challenge for ingress * Changes order to write configure-k0s script before installing Codesphere * Runs configure-k0s script after installation (enable installation in one command) * Allows passing skip steps and hash to bootstrap command
Signed-off-by: NautiluX <2600004+NautiluX@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.