Merged
Conversation
Member
Author
|
update the description to pxtarget.json libs instead of targetconfig.json |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a banner to generated files in order to prevent accidental edits. Key changes include a version bump in package.json and updating the CLI to prepend a generated file declaration to the projects markdown file.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated version from "11.4.7" to "11.4.8". |
| cli/cli.ts | Added GENERATED_FILE_DECLARATION and updated markdown generation for projects.md including proper newline formatting. |
Comments suppressed due to low confidence (1)
cli/cli.ts:1964
- The SUMMARY.md file is generated but does not include the generated file declaration. Consider prepending it with the GENERATED_FILE_DECLARATION to warn against manual edits.
nodeutil.writeFileSync(path.join(docsRoot, "docs/projects/SUMMARY.md"), tocmd, { encoding: "utf8" });
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent writing changes to generated files (and thus losing edits), we should label at the top of generated files to mention they're generated.
https://github.com/codewithher/Atisa-SSOT/issues/141