Allow (un)packing structs containing Vec<T> with #[derive(MsgPacker)]#15
Open
aurelj wants to merge 2 commits intocodx-dev:mainfrom
Open
Allow (un)packing structs containing Vec<T> with #[derive(MsgPacker)]#15aurelj wants to merge 2 commits intocodx-dev:mainfrom
aurelj wants to merge 2 commits intocodx-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the following code doesn't work:
because
Vec<T>doesn't implementPackable.This PR changes the binary (un)packer to apply to a new
MsgPackerBinwrapper type used to markVec<u8>that should be encoded as msgpack binary format.This free the way to implement (Un)Packable for
Vec<T>and thus allowsVec<T>to be packed as msgpack array format, fixing the above mentioned code.