feat: Publish icons 2026/05/21#712
Open
adrienzheng-cb wants to merge 4 commits into
Open
Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
…g IconName The sync-icon-code-connect script previously generated entries for every Figma ui/* and nav/* component set without validating against the IconName type. This produced 12 typecheck errors for entries like `tiktokLogo`, `baseLogo`, `priceAlerts ` (trailing space), and `newsfeed` (wrong case). The script now reads packages/icons/src/IconName.ts and skips component sets whose generated name doesn't appear there. Also trims whitespace from raw Figma names before camelCasing. 10 entries dropped (566 → 556). Co-authored-by: Cursor <cursoragent@cursor.com>
cb-ekuersch
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Sync icons from Figma.
New icon sets (4)
parlaysEmptyparlaysAddaddModuleUIopenBookDeleted / Renamed / Updated
None.
Code Connect entries regenerated (566 entries for web and mobile).
Root cause (required for bugfixes)
N/A
UI changes
See Percy visual regression results from the "Visreg Web" GitHub Actions job.
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false