feat: Select theming#733
Merged
Merged
Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
hcopp
commented
May 28, 2026
| labelVariant={labelVariant} | ||
| onBlur={onBlur} | ||
| onFocus={onFocus} | ||
| style={style} |
Resolve changelog and version conflicts: keep 9.2.0 for Select theming and include master 9.1.3 entries (StickyFooter fix, version sync). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
hcopp
commented
May 28, 2026
| rotate={open ? 0 : 180} | ||
| /> | ||
| )} | ||
| {customEndNode ? customEndNode : <AnimatedCaret color="fg" rotate={open ? 0 : 180} />} |
Contributor
Author
There was a problem hiding this comment.
I realized our carets are supposed to be fg at all times
This is true even when disabled, solely relying on the lower opacity to "dim" the caret
cb-ekuersch
previously approved these changes
Jun 8, 2026
| bordered = true, | ||
| borderWidth = bordered ? 100 : 0, | ||
| focusedBorderWidth = bordered ? undefined : 200, | ||
| inputBackground = !disabled && readOnly ? 'bgSecondary' : 'bg', |
Contributor
There was a problem hiding this comment.
nit: do you think we should document this behavior when there is business logic/computation involved in the default behavior? Perhaps a brief mention in the jcdocs
Contributor
Author
There was a problem hiding this comment.
Good call, let me update JSDocs
| rotate={open ? 0 : 180} | ||
| /> | ||
| )} | ||
| {customEndNode ? customEndNode : <AnimatedCaret color="fg" rotate={open ? 0 : 180} />} |
cb-ekuersch
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR adds support for several select theming features, including readOnly support.
UI changes
Testing
How has it been tested?
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false