fix: allow MiniKit auto-connect to retry after disconnect#2599
Open
jaffarkeikei wants to merge 1 commit intocoinbase:mainfrom
Open
fix: allow MiniKit auto-connect to retry after disconnect#2599jaffarkeikei wants to merge 1 commit intocoinbase:mainfrom
jaffarkeikei wants to merge 1 commit intocoinbase:mainfrom
Conversation
The AutoConnect component was only attempting to connect once due to the hasAttemptedConnection ref never being reset. After a user disconnects, the ref would remain true, preventing auto-connect from running again. This fix resets hasAttemptedConnection when the user disconnects (when isConnected and isConnecting are both false), allowing auto-connect to work properly after a disconnect in Base App. Fixes coinbase#2596
🟡 Heimdall Review Status
|
|
@jaffarkeikei is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
|
Review Error for 0xsarawut @ 2026-01-27 21:04:28 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2596
The
AutoConnectcomponent was only attempting to connect once due to thehasAttemptedConnectionref never being reset. After a user disconnects in Base App, the ref would remaintrue, preventing auto-connect from running again — causing the Connect button to do nothing.The Problem
After disconnect:
hasAttemptedConnection.currentis stilltrueThe Fix
Reset
hasAttemptedConnectionwhen the user disconnects:Testing
Added test case: "should attempt reconnection after disconnect" that verifies: