Skip to content

Add LogicNodes to ecosystem — 242 A2A workers, x402 on Base, Bazaar-d…#177

Open
cmdenney wants to merge 1 commit into
coinbase:mainfrom
cmdenney:add-logicnodes-ecosystem
Open

Add LogicNodes to ecosystem — 242 A2A workers, x402 on Base, Bazaar-d…#177
cmdenney wants to merge 1 commit into
coinbase:mainfrom
cmdenney:add-logicnodes-ecosystem

Conversation

@cmdenney
Copy link
Copy Markdown

…iscoverable

Description

Tests

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits
  • I added a changelog fragment for user-facing changes (docs-only changes can skip)

@cb-heimdall
Copy link
Copy Markdown

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@TateLyman
Copy link
Copy Markdown

Quick no-payment launch-readiness pass on the live LogicNodes surface, public endpoints only. I did not send X-PAYMENT, signatures, credentials, or paid calls.

What looks good:

  • https://logicnodes.io/discovery/resources?limit=2 is reachable and reports total: 256 resources with Base USDC pricing and resource-bound /call/... URLs.
  • Sampled POST /call/... routes return structured 402 challenges under the response body detail field.

Patch notes before browser clients rely on this listing:

  • Sampled actual 402 responses do not include Access-Control-Allow-Origin, so browser clients cannot read the payment requirements from fetch().
  • Sampled OPTIONS preflights return 405 with no Access-Control-Allow-Headers, so browser clients cannot retry with X-PAYMENT / PAYMENT-SIGNATURE.
  • Sampled 402 responses did not send Cache-Control; for payment challenges I would send no-store / private.
  • This PR title says 242 workers, but the live Bazaar-style discovery response currently reports total: 256.
  • https://logicnodes.io/.well-known/x402 returns 404; if the intended discovery surface is only /discovery/resources, the listing may want to state that explicitly.
  • https://logicnodes.io/.well-known/mcp-config includes LOGICNODES_API_KEY in the Claude Desktop config while the PR says no signup. Worth clarifying whether the MCP bridge needs an API key while the direct x402 routes do not.

Repro example:

npx --yes x402-surface-check@0.2.37 --endpoint --method POST https://logicnodes.io/call/mev_protection_score --origin https://logicnodes.io --strict-cache

Sampled routes: mev_protection_score, cross_dock_scheduler, prediction_market_oracle. Happy to rerun after patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants