Open
Conversation
hxzhao527
commented
Mar 16, 2025
hxzhao527
commented
- eliminate the magic number in size_for
- fix Elf32_Sym define
hxzhao527
commented
Mar 17, 2025
src/symbol.rs
Outdated
| pub st_size: u32, | ||
| pub st_info: u8, | ||
| pub st_other: u8, | ||
| pub st_shndx: u32, |
Author
There was a problem hiding this comment.
st_shndx type should be uint16_t.
reference:
1. eliminate the magic number in size_for 2. fix Elf32_Sym define
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.