DRYD-1979 Security > Integrate Security Vulnerability Scanners #498
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
It extends the github PR template with a security vulnerabilities check step.
Why are we doing this? (with JIRA link)
We need to check for security vulnerabilities also while creating static code in IDE: https://collectionspace.atlassian.net/browse/DRYD-1979
How should this be tested? Do these changes have associated tests?
no need for test
Dependencies for merging? Releasing to production?
no dependencies
Has the application documentation been updated for these changes?
We need to update the https://collectionspace.atlassian.net/wiki/spaces/CPD/pages/3994779662/Secure+Software+Development+Lifecycle
and https://lyrasis.sharepoint.com/:x:/r/sites/DTS/Shared%20Documents/Security%20Documents/Lyrasis-CollectionSpace-Full-HECVAT-%204.1.2.xlsx?d=w789089b9614c4287a074b0b80d59d8b3&csf=1&web=1&e=I4vbjr&nav=MTVfezRGN0RGQzlFLTMwMDAtNERCMy04NzE1LUU0MkVEQTQyQUUwRH0
when done.
Did someone actually run this code to verify it works?
@spirosdi installed SonarQube linter in his IDE and it looks fine