Comaptibility with dev branch of PoseLib#186
Open
VladyslavZavadskyi wants to merge 2 commits intocolmap:mainfrom
Open
Comaptibility with dev branch of PoseLib#186VladyslavZavadskyi wants to merge 2 commits intocolmap:mainfrom
dev branch of PoseLib#186VladyslavZavadskyi wants to merge 2 commits intocolmap:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the previous pull-request (#185).
Tested with this commit.
There's no comprehensive benchmark, unfortunately. But, I've ran it on a scene of 3648 images and it was able to register 3453 of them. While the version without it was registering only 9, with the same config.
I'm not sure why this is, but since dev PoseLib has more camera models, it may have to deal with fallbacks when a used camera model is not defined in PoseLib.