Skip to content

Migration dart2#88

Closed
MathieuAuclair wants to merge 3 commits into
masterfrom
migration_dart2
Closed

Migration dart2#88
MathieuAuclair wants to merge 3 commits into
masterfrom
migration_dart2

Conversation

@MathieuAuclair

Copy link
Copy Markdown
Collaborator

Update dependencies to fit SDK 2.1.0+

Take note that flutter test/build is no longer a valid tool

❯  flutter packages pub run build_runner test

Comment thread pubspec.yaml
path: "^1.4.2"
comiko_shared:
git: https://github.com/comiko-app/shared.git
path: ../comiko_dependencies/shared

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idéalement on garde les deps en .git

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On ne peut pas, git n'est pas supporté sur dart 2 étrangement

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol n'importe quoi, les deps git fonctionnent encore.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

le problème est probablement plus que "shared" n'est pas encore OK pour dart 2.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je vais checker, quel est ta version de sdk?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2+

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moi je suis sur 2.1, je vais vérifier si le problème persiste

@MathieuAuclair

Copy link
Copy Markdown
Collaborator Author

le travis semble complètement explosé selon flutter doctor https://travis-ci.org/comiko-app/comiko/builds/424860714?utm_source=github_status&utm_medium=notification

@MathieuAuclair

MathieuAuclair commented Sep 5, 2018

Copy link
Copy Markdown
Collaborator Author

J'ai une config dans un de mes repos privé, IOS fonctionne, android à cessé de fonctionner dernièrement, je vais aller la réparer et je vais l'importer sur comiko via une autre pull request

@MathieuAuclair

Copy link
Copy Markdown
Collaborator Author

Merged in #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants