Make sure the header for Job Token matches the type of Token#16
Open
Make sure the header for Job Token matches the type of Token#16
Conversation
Contributor
Author
|
Ok, tested a lot, got it working, I think I have a pretty solid workflow now, on Gitlab. If you want to clean anything up, or squash stuff, I understand. |
elpete
reviewed
Sep 5, 2023
| print.boldWhiteOnBlackLine( "Version Info" ).toConsole(); | ||
| print.table( [ versionInfo ] ).toConsole(); | ||
|
|
||
| return semanticVersion.getVersionAsString( versionInfo ) |
Collaborator
There was a problem hiding this comment.
With the new preReleaseID and buildID, how does it generate release versions? I don't want my release versions to look like 5.1.0+0. (I don't want a buildID at all.)
As long as the buildID is completely optional, this should be good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got error using the module.
415 Unsupported Media Type
POST https://hac-ci.revagency.net/api/v4/projects/173/releases
Looks like we need the content type to go with it.
Testing locally, with Personal Access Token, it worked.
Should update the Header for the token type as well.
Maybe we should give them the option of the token type, but at least should work now.