Skip to content

Fix border radius #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berardomate wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix border radius #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7257371
fix: border-radius sizes
berardomate Apr 2, 2026
db2289d
fix: new dropdown
berardomate Apr 2, 2026
f6bc1b1
chore: run lint
gciotola Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/app-elements/src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
--breakpoint-xl: 1280px;

--radius-*: initial;
--radius: 0.313rem;
--radius-sm: 0.188rem;
--radius-md: 0.625rem;
--radius: 0.5rem;
--radius-sm: 0.25rem;
--radius-md: 1rem;
--radius-full: 9999px;

--color-*: initial;
Expand Down
2 changes: 1 addition & 1 deletion packages/app-elements/src/ui/composite/Dropdown/DropdownDivider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const DropdownDivider: FC<DropdownDividerProps> = ({
}) => {
return (
<div {...rest} className="h-px my-2">
<hr className="border-gray-600" />
<hr className="border-gray-200" />
</div>
)
}
Expand Down
4 changes: 2 additions & 2 deletions packages/app-elements/src/ui/composite/Dropdown/DropdownItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,14 @@ export const DropdownItem = withSkeletonTemplate<DropdownItemProps>(
}}
href={href}
className={cn(
"w-full bg-black text-white! py-1.5 pl-4 text-sm font-medium flex items-center focus:outline-hidden!",
"w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-4 mx-2 text-sm font-regular flex items-center focus:outline-hidden!",
{
"pr-8": info == null,
"min-w-[250px] pr-6": info != null,
},
className,
{
"hover:bg-gray-600 cursor-pointer focus:bg-gray-600 group":
"hover:bg-gray-100 hover:rounded cursor-pointer focus:bg-gray-100 group":
onClick != null || href != null,
"cursor-default": onClick == null && href == null,
"opacity-50 pointer-events-none": isDisabled,
Expand Down
6 changes: 3 additions & 3 deletions packages/app-elements/src/ui/composite/Dropdown/DropdownMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const DropdownMenu: FC<DropdownMenuProps> = ({
<div
{...rest}
className={cn(
"bg-black text-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2",
"bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg",
{
"min-w-[150px] md:max-w-[250px]": menuWidth == null, // default width
"w-[280px]": menuWidth === "wide",
Expand All @@ -65,7 +65,7 @@ export const DropdownMenu: FC<DropdownMenuProps> = ({
{menuHeader != null && (
<>
<div
className="py-2 px-4 text-gray-400 text-xs font-semibold text-ellipsis overflow-hidden whitespace-nowrap"
className="py-2 px-4 text-gray-800 text-xs font-semibold text-ellipsis overflow-hidden whitespace-nowrap"
title={menuHeader}
>
{menuHeader}
Expand Down Expand Up @@ -111,7 +111,7 @@ const Arrow: FC<{

return (
<span
className="relative border-black border-l-transparent border-r-transparent"
className="relative border-gray-200 border-l-transparent border-r-transparent"
style={{
// base styles
borderLeftWidth: arrowWidth / 2,
Expand Down
24 changes: 12 additions & 12 deletions packages/app-elements/src/ui/composite/Dropdown/__snapshots__/Dropdown.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ exports[`Dropdown > Should be rendering bottom-left 1`] = `
class="flex flex-col items-start"
>
<span
class="relative border-black border-l-transparent border-r-transparent"
class="relative border-gray-200 border-l-transparent border-r-transparent"
style="border-left-width: 6px; border-right-width: 6px; border-bottom-width: 5px; border-top-color: transparent; left: 10px;"
/>
<div
class="bg-black text-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 min-w-[150px] md:max-w-[250px]"
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-[150px] md:max-w-[250px]"
>
<div />
</div>
Expand Down Expand Up @@ -76,11 +76,11 @@ exports[`Dropdown > Should be rendering top-left 1`] = `
class="flex flex-col-reverse items-start"
>
<span
class="relative border-black border-l-transparent border-r-transparent"
class="relative border-gray-200 border-l-transparent border-r-transparent"
style="border-left-width: 6px; border-right-width: 6px; border-top-width: 5px; border-bottom-color: transparent; left: 10px;"
/>
<div
class="bg-black text-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 min-w-[150px] md:max-w-[250px]"
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-[150px] md:max-w-[250px]"
>
<div />
</div>
Expand Down Expand Up @@ -121,11 +121,11 @@ exports[`Dropdown > Should be rendering top-right 1`] = `
class="flex flex-col-reverse items-end"
>
<span
class="relative border-black border-l-transparent border-r-transparent"
class="relative border-gray-200 border-l-transparent border-r-transparent"
style="border-left-width: 6px; border-right-width: 6px; border-top-width: 5px; border-bottom-color: transparent; right: 10px;"
/>
<div
class="bg-black text-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 min-w-[150px] md:max-w-[250px]"
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-[150px] md:max-w-[250px]"
>
<div />
</div>
Expand Down Expand Up @@ -166,15 +166,15 @@ exports[`Dropdown > Should be rendering with default bottom-right position 1`] =
class="flex flex-col items-end"
>
<span
class="relative border-black border-l-transparent border-r-transparent"
class="relative border-gray-200 border-l-transparent border-r-transparent"
style="border-left-width: 6px; border-right-width: 6px; border-bottom-width: 5px; border-top-color: transparent; right: 10px;"
/>
<div
class="bg-black text-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 min-w-[150px] md:max-w-[250px]"
class="bg-white rounded overflow-x-hidden overflow-y-auto max-h-[450px] py-2 border shadow-lg min-w-[150px] md:max-w-[250px]"
>
<button
aria-label="Payments"
class="w-full bg-black text-white! py-1.5 pl-4 text-sm font-medium flex items-center focus:outline-hidden! pr-8 hover:bg-gray-600 cursor-pointer focus:bg-gray-600 group"
class="w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-4 mx-2 text-sm font-regular flex items-center focus:outline-hidden! pr-8 hover:bg-gray-100 hover:rounded cursor-pointer focus:bg-gray-100 group"
>
<div
class="mr-2"
Expand All @@ -200,7 +200,7 @@ exports[`Dropdown > Should be rendering with default bottom-right position 1`] =
</button>
<button
aria-label="Items"
class="w-full bg-black text-white! py-1.5 pl-4 text-sm font-medium flex items-center focus:outline-hidden! pr-8 hover:bg-gray-600 cursor-pointer focus:bg-gray-600 group"
class="w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-4 mx-2 text-sm font-regular flex items-center focus:outline-hidden! pr-8 hover:bg-gray-100 hover:rounded cursor-pointer focus:bg-gray-100 group"
>
<div
class="mr-2"
Expand All @@ -220,12 +220,12 @@ exports[`Dropdown > Should be rendering with default bottom-right position 1`] =
class="h-px my-2"
>
<hr
class="border-gray-600"
class="border-gray-200"
/>
</div>
<button
aria-label="Delete"
class="w-full bg-black text-white! py-1.5 pl-4 text-sm font-medium flex items-center focus:outline-hidden! pr-8 hover:bg-gray-600 cursor-pointer focus:bg-gray-600 group"
class="w-[calc(100%-1rem)] bg-white text-black! py-1.5 pl-4 mx-2 text-sm font-regular flex items-center focus:outline-hidden! pr-8 hover:bg-gray-100 hover:rounded cursor-pointer focus:bg-gray-100 group"
>
<div
class="mr-2"
Expand Down
Loading