📚 docs(document): add SKUs story and upgrade Storybook to v10#735
Merged
📚 docs(document): add SKUs story and upgrade Storybook to v10#735
Conversation
…erver - Upgrade all @storybook/* packages to ^10.3.4 - Add @storybook/addon-mcp with .mcp.json MCP server config - Add stories/skus/001.skus.mdx with docs for all 5 SKU components - Add stories/skus/skus.stories.tsx with 3 visual-test stories - Add MSW mocks for /api/skus and /api/sku_lists/:id Closes #733
This was
linked to
issues
Apr 7, 2026
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #733
Closes #730
Relates to #727
@storybook/*packages to^10.3.4(from mixed v8/v10 state)@storybook/addon-mcp+.mcp.jsonMCP server config at repo rootpackages/document/src/stories/skus/001.skus.mdx— documentation for all 5 SKU components (SkusContainer,Skus,SkuField,SkuListsContainer,SkuList) with prop tables, requirement/children badges, and code examplespackages/document/src/stories/skus/skus.stories.tsx— interactive visual-test stories/api/skusand/api/sku_lists/:idBug fixes
SkuList—Skusrendered empty:SkuListwas registering the list ID but never bridging the fetched SKU data intoSkuContext, so<Skus>had nothing to iterate. Fixed by wrapping children withSkuContext.Providercontaining the resolvedskuLists[id]data.mocks/data/skus.jsandmocks/data/sku_lists.jswith matching codes and the correct SKU list ID (yZjQIDxrly).New features
SkuListsContainer—paramsprop: Added an optionalparams?: QueryParamsRetrieve<SkuList>prop. Default behavior keepsinclude: ["skus"](no fields filter → all SKU fields are returned). Consumers can pass any valid retrieve params to override or extend the default (e.g. restrict fields, add extra includes).SkuListsContainerstory (custom params) to demonstrate the newparamsprop with explicitincludeandfieldscustomization.Test plan
pnpm storybookstarts without errors inpackages/documentSkuListsContainer — default include (skus)story renders SKU name and code from the real APISkuListsContainer — custom paramsstory renders with explicit field selectionSkusContainer — name and codeandSkuField — imagestories render correctlypnpm --filter document run mcpstarts the MCP server