fix: dont delete new mandates when customer ID is reused #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r has priority over the generic
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where new mandates could be incorrectly deleted when a customer ID is reused in the GoCardless flow, and ensures proper webhook handler priority.
Changes:
- Added priority parameter (9) to webhook handler registration to ensure LRU-specific handler runs before the generic handler
- Added mandate ID parameter to
removeCustomerMandates()call to prevent deletion of the newly created mandate when customer ID is reused
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't happen, as every time someone goes through the GoCardless flow, they get a new Customer ID.
However, it is incorrect code, so should be fixed.
Also ensures that the LRU specific webhook handler is registered before the generic one (in the main plugin repo) so it takes priority.