fix: lint issues (mostly just ignored) after upgrading React #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses lint issues that surfaced after upgrading React to version 19.2.3. The changes primarily consist of code formatting improvements, dependency array optimizations for React hooks, ESLint configuration modernization, and the addition of eslint-disable comments to suppress new linting rules.
Changes:
- Modernized ESLint configuration to use flat config format with updated import paths
- Optimized React hook dependency arrays by using whole objects instead of individual properties
- Updated next-sanity import path from "next-sanity" to "next-sanity/live"
Reviewed changes
Copilot reviewed 11 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Formatting cleanup (collapsed array literals to single lines) |
| src/sanity/lib/live.ts | Updated import path for defineLive from "next-sanity" to "next-sanity/live" |
| src/components/forms/useForm.tsx | Code reformatting with eslint-disable comment for react-hooks/refs rule |
| src/app/map/[id]/hooks/useInspector.ts | Optimized dependency array to use whole selectedBoundary object |
| src/app/map/[id]/components/inspector/InspectorPanel.tsx | Formatting fix for Boolean expression indentation |
| src/app/map/[id]/components/inspector/InspectorDataTab.tsx | Optimized dependency array to use whole selectedBoundary object |
| src/app/map/[id]/components/inspector/InspectorConfigTab.tsx | Removed unnecessary useCallback wrappers around already-memoized functions |
| src/app/map/[id]/components/inspector/BoundaryDataPanel.tsx | Optimized dependency array to use whole data object instead of data?.json |
| src/app/map/[id]/components/controls/MarkersControl/MarkersControl.tsx | Formatting fix for Boolean expression indentation |
| src/app/map/[id]/components/ZoomControl.tsx | Added eslint-disable comment for react-hooks/refs rule |
| src/app/map/[id]/components/SearchBox.tsx | Removed ts-expect-error comment, added eslint-disable for react-hooks/refs |
| src/app/map/[id]/components/Legend.tsx | Extracted VisibilityToggle from nested function to standalone component |
| src/app/(private)/data-sources/[id]/DataSourceEnrichmentDashboard.tsx | Formatting fix for Boolean expression indentation |
| src/app/(private)/data-sources/[id]/DataSourceDashboard.tsx | Formatting fix for Boolean expression indentation |
| src/app/(auth)/invite/[token]/page.tsx | Added eslint-disable comment for react-hooks/immutability rule |
| eslint.config.mjs | Complete refactor to use ESLint 9 flat config with new import paths and configuration structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.