Skip to content

Fix Windows crash with non-ASCII locale thousands separators #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joffrey-b wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Windows crash with non-ASCII locale thousands separators #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ env:
jobs:
build_windows:
name: Windows
runs-on: windows-2025
runs-on: windows-2022
strategy:
fail-fast: false
env:
Expand Down
5 changes: 5 additions & 0 deletions src/rsgain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,12 @@ int main(int argc, char *argv[]) {
{ "version", no_argument, nullptr, 'v' },
{ 0, 0, 0, 0 }
};
#ifndef _WIN32
// On Windows, the CRT's numpunct facet crashes when accessed for locales that use
// non-ASCII thousands separators (e.g. French NARROW NO-BREAK SPACE U+202F), which
// is triggered by the {:L} format specifiers used for locale-aware number output.
try { std::locale::global(std::locale("")); } catch(...) {}
#endif
av_log_set_callback(nullptr);

#ifdef _WIN32
Expand Down
Loading