Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an infinite retry loop issue that occurred after machine restarts by implementing runner configuration persistence using Docker named volumes.
- Adds a new
github_runner_persist_configvariable (defaults totrue) to enable/disable configuration persistence - Mounts a named Docker volume (
<runner-name>-runner-data:/runner-data) to persist runner configuration files - Sets the
CONFIGURED_ACTIONS_RUNNER_FILES_DIRenvironment variable to point to the persisted volume location
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| roles/github_runner/tasks/main.yml | Adds conditional volume mount for runner configuration persistence and sets the CONFIGURED_ACTIONS_RUNNER_FILES_DIR environment variable when persistence is enabled |
| roles/github_runner/defaults/main.yml | Introduces the github_runner_persist_config variable with a default value of true |
| README.md | Documents the new github_runner_persist_config variable and its purpose |
| galaxy.yml | Bumps the collection version from 0.1.0 to 0.1.1 for this patch release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ['/var/run/docker.sock:/var/run/docker.sock'] + | ||
| (['/root/.android:/root/.android'] if github_runner_android else []) | ||
| (['/root/.android:/root/.android'] if github_runner_android else []) + | ||
| ([github_runner_name ~ '-runner-data:/runner-data'] if github_runner_persist_config else []) |
There was a problem hiding this comment.
The new persistence feature introduced in this PR is not covered by any test scenarios. Consider adding test coverage to verify that:
- The named volume is correctly mounted when
github_runner_persist_configistrue - The
CONFIGURED_ACTIONS_RUNNER_FILES_DIRenvironment variable is set when persistence is enabled - The volume and environment variable are not present when
github_runner_persist_configisfalse
This is particularly important since this feature aims to fix an infinite retry loop issue after machine restarts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was having an issue where it would get stuck in infinite retry loop after machine restarts