fix: run plugin after all variables resolved#10
Open
Luke-Davies wants to merge 1 commit intoconcon121:masterfrom
Open
fix: run plugin after all variables resolved#10Luke-Davies wants to merge 1 commit intoconcon121:masterfrom
Luke-Davies wants to merge 1 commit intoconcon121:masterfrom
Conversation
Author
|
@concon121 Any chance this could be looked at and merged in? If you are looking for help maintaining this project then I would be interested in taking it on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variables that have a delayed resolution will not be resolved before the plugin runs. This affects custom variables.
For example:
or
resourceNamesPrefixmay not be resolved before the plugin executes, so the unresolved variable string is used. I'm seeing this occur on a simple serverless file where I use a plugin to load common environment config from S3:This is mentioned in the docs:
This PR fixes this by executing the plugin on a hook as described in the docs.