Feature/combine agentspan#155
Open
kowser-orkes wants to merge 4 commits into
Open
Conversation
Copy the Agentspan .NET SDK (upstream agentspan-ai/agentspan @ f8704fa3, sdk/csharp) into the Conductor C# SDK as 9 new solution projects plus an examples tree with its own solution: - Conductor.AI (+ OpenAI / GoogleADK / SemanticKernel adapters), published as conductor-ai, conductor-ai-openai, conductor-ai-google-adk, conductor-ai-semantic-kernel - Conductor.AI.Tests + 3 adapter test projects (renamed from Agentspan.*) - Conductor.AI.E2eTests (renamed from AgentspanE2eTests) - Conductor.AI.Examples/ with Conductor.AI.Examples.sln (175 examples) - docs/agents/ (verbatim; content pass in a later stage) Sources are copied verbatim. Build-level conformance to the target repo standard: TargetFramework net8.0, conductor-csharp 1.1.4 PackageReference replaced by a ProjectReference, exemplar-shaped csproj metadata, Apache-2.0 license headers replacing MIT, dotnet format applied. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Validation-gate fixes, both build-level (no source changes): - Conductor.AI: reference System.Text.Json 9.0.9 — JsonSchemaExporter (System.Text.Json.Schema) is in-box on .NET 9+/10 but needs the NuGet package on net8.0. Only compile error in the entire net10->net8 retarget. - Sk01_BasicAgent: repoint ProjectReferences that used backslash paths (the only csproj the forward-slash path rewrite missed). Gate results on dotnet 8.0.422: - build: conductor-csharp.sln clean, 0 errors - unit: existing tests 51/51; Conductor.AI 56 + OpenAI 13 + GoogleADK 5 + SemanticKernel 5 = 79/79 - format: dotnet format --verify-no-changes clean on all shipped projects; zero MIT headers remain - examples: all 175 projects in Conductor.AI.Examples.sln compile - e2e: 145 passed / 0 failed / 8 key-gated skips vs released agentspan-server-0.4.0.jar + mcp-testkit - pack dry-run: conductor-ai, conductor-ai-openai, conductor-ai-google-adk, conductor-ai-semantic-kernel @ -p:Version, conductor-csharp dependency tracks the injected version, no MIT metadata - vacuous-run guard: fails correctly on dead server (101 skips would otherwise report "Passed!") Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…stages (Stage 3) - agent-e2e.yml (new): runs Conductor.AI.E2eTests against the released agentspan-server-0.4.0.jar (cached gh release download, :8080 health gate) with mcp-testkit on :3001. LLM keys are job-level repo secrets (server consumes them; some suites key-gate on the test env — upstream parity). A TRX guard fails the job when 0 tests executed OR when suites skipped because the server was unreachable — with a dead server dotnet test reports "Passed!" with 101 skips, so exit-code alone would green-wash. - pull_request.yml: unit_tests job gains the 4 agent unit test projects (79 tests, same coverage collection); new build_ai_examples job compiles all 175 examples via Conductor.AI.Examples.sln. - Dockerfile: base stage copies the Conductor.AI* projects (+ root README for package readme resolution); linter stage format-checks the 4 shipped agent csprojs; pack_release packs conductor-ai, conductor-ai-openai, conductor-ai-google-adk, conductor-ai-semantic-kernel at the same tag-driven version — publish_release's existing *.symbols.nupkg glob publishes them, so release.yml needs no changes. Validated: actionlint clean on both workflows; docker build --target=linter passes locally; guard verified on real (145 executed -> OK) and vacuous (52 executed / 94 unreachable-skips -> exit 1) runs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- docs/agents/: package ids conductor-agent-sdk* -> conductor-ai*, target .NET 10 -> .NET 8, SDK-brand prose -> Conductor AI (server/runtime references and the AGENTSPAN_* env contract intentionally unchanged); all internal links verified. - README.md: AI Agents section with the conductor-ai install snippet and a pointer to docs/agents. - CHANGELOG.md: Unreleased "Added" entry for the merge, with a migration note for conductor-agent-sdk package users. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.