deprecate IsHeaderField without dd#1007
Merged
Merged
Conversation
IsHeaderField(tag) without the DD param should be discouraged, because custom DDs might add other header fields that need to be matched. Removed internal usages of it and deprecated it. resolves connamara#562
trevor-bush
approved these changes
Apr 13, 2026
Technically a public-interface breakage, but doubtful anyone will be affected
gbirchmeier
force-pushed
the
IsHeaderField-i562
branch
from
6fd3f7d to
77d4de4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsHeaderField(tag) without the DD param should be discouraged, because custom DDs might add other header fields that need to be matched. Removed internal usages of it and deprecated it.
resolves #562