cpuid: allow unused unsafes#585
Merged
jakecorrenti merged 2 commits intocontainers:mainfrom Mar 13, 2026
Merged
Conversation
Collaborator
slp
commented
Mar 13, 2026
slp
commented
slp
requested review from
MatiasVara,
dorindabassey,
jakecorrenti,
mtjhrc and
tylerfanelli
as code owners
Collaborator
Author
|
cc/ @d-e-s-o |
This reverts commit fb42ebf. Signed-off-by: Sergio Lopez <slp@redhat.com>
Rust 1.94 has switched a number of cpuid-related methods from unsafe to safe. We initially removed the "unsafe" block to make clippy happy, but this would make libkrun harder to package on distros that are a bit conservative with their Rust versions. Since there isn't any real impact, let's temporarily allow unused unsafes on the affected methods instead. Suggested-by: Daniel Müller <deso@posteo.net> Signed-off-by: Sergio Lopez <slp@redhat.com>
slp
force-pushed
the
allow-unused-unsafe
branch
from
61d7883 to
9bffe3c
Compare
d-e-s-o
approved these changes
Mar 13, 2026
Contributor
d-e-s-o
left a comment
d-e-s-o
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.