devices: build init binary in Cargo OUT_DIR#586
Open
d-e-s-o wants to merge 1 commit intocontainers:mainfrom
Open
devices: build init binary in Cargo OUT_DIR#586d-e-s-o wants to merge 1 commit intocontainers:mainfrom
OUT_DIR#586d-e-s-o wants to merge 1 commit intocontainers:mainfrom
Conversation
As per previous discussion [0], adjust the build script to build the init binary in Cargo's OUT_DIR, which is meant precisely for use cases like this. This way, we don't leak a random binary into the source tree, where it would have to be removed manually. [0] containers#578 (comment) Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
requested review from
MatiasVara,
dorindabassey,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
jakecorrenti
approved these changes
Mar 13, 2026
Member
jakecorrenti
left a comment
jakecorrenti
left a comment
There was a problem hiding this comment.
LGTM, thanks for making the change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per previous discussion [0], adjust the build script to build the
initbinary in Cargo'sOUT_DIR, which is meant precisely for use cases like this. This way, we don't leak a random binary into the source tree, where it would have to be removed manually.[0] #578 (comment)