libkrun: Produce a proper Rust library#588
Draft
d-e-s-o wants to merge 2 commits intocontainers:mainfrom
Draft
Conversation
Make all workspace members compatible with vm-memory in version 0.18 and remove the dependency on vm-memory 0.16.2. Also fix up the version range specification, which was not correct (at least one version was not actually building) and in any event untested. The reason we need this change is because we need to use a single version of vm-memory, or we will see type/trait mismatches due to semver incompatible versions being used. Signed-off-by: Daniel Müller <deso@posteo.net>
Contributor
Author
|
Still blocked on rust-vmm/linux-loader#223 and it being included in a new release. |
d-e-s-o
force-pushed
the
topic/rust-lib
branch
3 times, most recently
from
2f00f43 to
5987285
Compare
Produce a proper Rust library to avoid the need for C library
installation as well as binding generation/definition. Basically, we can
now reference the crate via Cargo.toml:
[dependencies]
libkrun = ...
instead of having to rely on constructs like:
#[link(name = "krun")]
extern "C" {
pub fn krun_create_ctx() -> i32;
...
}
Signed-off-by: Daniel Müller <deso@posteo.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Produce a proper Rust library to avoid the need for C library
installation as well as binding generation/definition. Basically, we can
now reference the crate via
Cargo.toml:instead of having to rely on constructs like:
For a brief discussion of the topic, see #494 (comment)