Skip to content

cmd: Use $TOOLBOX_DEFAULT_CONTAINER to populate --container #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whot wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

cmd: Use $TOOLBOX_DEFAULT_CONTAINER to populate --container #1774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cmd/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func init() {
flags.StringVarP(&createFlags.container,
"container",
"c",
"",
os.Getenv("TOOLBOX_DEFAULT_CONTAINER"),
"Assign a different name to the Toolbx container")

flags.StringVarP(&createFlags.distro,
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/enter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func init() {
flags.StringVarP(&enterFlags.container,
"container",
"c",
"",
os.Getenv("TOOLBOX_DEFAULT_CONTAINER"),
"Enter a Toolbx container with the given name")

flags.StringVarP(&enterFlags.distro,
Expand Down
2 changes: 1 addition & 1 deletion src/cmd/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func init() {
flags.StringVarP(&runFlags.container,
"container",
"c",
"",
os.Getenv("TOOLBOX_DEFAULT_CONTAINER"),
"Run command inside a Toolbx container with the given name")

flags.StringVarP(&runFlags.distro,
Expand Down
1 change: 1 addition & 0 deletions src/pkg/utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ var (
"SHELL",
"SSH_AUTH_SOCK",
"TERM",
"TOOLBOX_DEFAULT_CONTAINER",
Copy link

@gemini-code-assist gemini-code-assist bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding TOOLBOX_DEFAULT_CONTAINER to preservedEnvironmentVariables causes it to be passed from the host into containers during toolbox run. This leaks host-side tool configuration into the container's environment, which can lead to unexpected behavior and breaks isolation. For example, a script inside a container might behave differently depending on the host's TOOLBOX_DEFAULT_CONTAINER setting.

To avoid this, please remove this variable from the list. The main feature of this PR (using the variable on the host) will still work correctly.

Copy link
Author

@whot whot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to wait for human confirmation of this because if the above is correct, I misunderstood it completely :) in my testing this was needed to get a toolbox foo to run correctly when running within a toolbox itself.

"TOOLBOX_PATH",
"USER",
"VTE_VERSION",
Expand Down