Skip to content

Add butane schemas for CoreOS and Flatcar#698

Open
Nemric wants to merge 3 commits intocoreos:mainfrom
Nemric:feat-add-butane-schemas
Open

Add butane schemas for CoreOS and Flatcar#698
Nemric wants to merge 3 commits intocoreos:mainfrom
Nemric:feat-add-butane-schemas

Conversation

@Nemric
Copy link
Copy Markdown
Contributor

@Nemric Nemric commented Apr 16, 2026

Json schemas are wildly used in IDEs to help anyone that use yaml or json files to write configs
see : coreos/fedora-coreos-tracker#2074

For now, files schemas are set to https://coreos.github.io/butane/schemas/** depending where the files will be hosted when merged ;)

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'schemas' subproject to commit be8bc36157f3d48e614f673835a2dcd85f5ab022. I have no feedback to provide.

@Nemric Nemric force-pushed the feat-add-butane-schemas branch 3 times, most recently from 5ee405d to b57a0ae Compare April 20, 2026 15:23
@Nemric Nemric marked this pull request as ready for review April 20, 2026 15:25
@Nemric Nemric force-pushed the feat-add-butane-schemas branch 2 times, most recently from e944247 to c684976 Compare April 20, 2026 19:44
Copy link
Copy Markdown
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had wished that those could be generated but in the meantime it's OK to include what we have an we'll see how to automate later. Thanks for pushing those :)

Comment thread docs/release-notes.md Outdated
Comment thread schemas/flatcar/v1.1.0/1.1.0.json
Comment thread schemas/v1.7.0/testconfig.bu Outdated
@@ -0,0 +1,149 @@
{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, what are those fort? If it's for an experimental version then it should be under there?

Copy link
Copy Markdown
Contributor Author

@Nemric Nemric Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is used for dev/local purpose
It's called by the dev.bu file to test local things, without that we should create a "how to contribute" file with this sample
[edit] It's essentially called by *.bu files in directories e.g. fcos/v1.7.0/1.7.0.bu for validation
I also have in my repo a github action that validate *.bu files and json files
dev.bu dropped as useless
[edit] I added an updated version of the github action that validate schemas ... don't really know how to test it without merging it 😕

Comment thread schemas/README.md Outdated
Comment thread schemas/README.md Outdated
Comment thread schemas/README.md Outdated
Comment thread schemas/README.md Outdated
Comment thread schemas/README.md Outdated
Comment thread schemas/README.md
Comment on lines +32 to +34
## List of clients that use uses the Red hat YAML extension

[some known clients consuming Red hat YAML extension](https://github.com/redhat-developer/yaml-language-server?tab=readme-ov-file#clients)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify why we need this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's informative only ... can be dropped, or not

@Nemric
Copy link
Copy Markdown
Contributor Author

Nemric commented Apr 21, 2026

I had wished that those could be generated but in the meantime it's OK to include what we have an we'll see how to automate later. Thanks for pushing those :)

Yes, that could be a great step, sure AI can do things based on spec files ...

@Nemric Nemric force-pushed the feat-add-butane-schemas branch 4 times, most recently from 45999de to 3a596c7 Compare April 21, 2026 15:54
@Nemric Nemric force-pushed the feat-add-butane-schemas branch from 3a596c7 to ebd13b6 Compare April 21, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants